Fix buffer terminator overwrite in jt_message_prep

NT7S · NT7S · commit 6b9b78d8b1d1 · 2021-06-30T17:54:52.000-07:00
diff --git a/src/JTEncode.cpp b/src/JTEncode.cpp
@@ -578,12 +578,10 @@ void JTEncode::jt_message_prep(char * message)
 
   // Pad the message with trailing spaces
   uint8_t len = strlen(message);
-  if(len < 13)
+  
+  for(i = len; i < 13; i++)
   {
-    for(i = len; i <= 13; i++)
-    {
-      message[i] = ' ';
-    }
+    message[i] = ' ';
   }
 
   // Convert all chars to uppercase

Original file line number	Diff line number	Diff line change
`@@ -578,12 +578,10 @@ void JTEncode::jt_message_prep(char * message)`
`578`	`578`
`579`	`579`	`// Pad the message with trailing spaces`
`580`	`580`	`uint8_t len = strlen(message);`
`581`		`- if(len < 13)`
	`581`	`+`
	`582`	`+ for(i = len; i < 13; i++)`
`582`	`583`	`{`
`583`		`- for(i = len; i <= 13; i++)`
`584`		`- {`
`585`		`- message[i] = ' ';`
`586`		`- }`
	`584`	`+ message[i] = ' ';`
`587`	`585`	`}`
`588`	`586`
`589`	`587`	`// Convert all chars to uppercase`