Change etherscan's "getHistory" query sort to DESC / Accept "sort" parameter

[xdzurman]

Describe the Feature

Currently, real pagination of "newest-first" data is cumbersome to implement, since results are fetched in "ascending" order. With this change, all the library's client would need to do is call the API once, get 10000 results, and then query the next page using block from the last transaction. Nonetheless, IMHO whenever there's a constrained result set, the newer results are more important than the oldest ones.

Optionally, this could be done via another optional function parameter, but that would require more work (documentation, tests. calls throughout the code)

Code Example

implemented in a PR here https://github.com/ethers-io/ethers.js/pull/3108

[ricmoo]

This is definitely a breaking change and would affect many users already using the API.

Changes must be backwards compatible.

I likely won’t make any change in v5, as v6 introduces a pagination API which the History API will use.

[xdzurman]

Right. When would v6 be available please?

[ricmoo]

There is a v6 beta ready now, but the pagination for Etherscan has not been added yet; as such expect the EtherscanProvider API to change.