refactor: use slices.Contains to simplify code (#5087)

Signed-off-by: CoolCu <[email protected]>

Author: CoolCu

pkg/api/router_test.go

@@ -6,6 +6,7 @@ package api_test
 
 import (
 	"net/http"
+	"slices"
 	"strings"
 	"testing"
 
@@ -427,7 +428,7 @@ func TestEndpointOptions(t *testing.T) {
 					actualMethods := strings.Split(allowHeader, ", ")
 
 					for _, expectedMethod := range tt.expectedMethods {
-						if !contains(actualMethods, expectedMethod) {
+						if !slices.Contains(actualMethods, expectedMethod) {
 							t.Errorf("expected method %s not found for route %s", expectedMethod, tt.route)
 						}
 					}
@@ -436,12 +437,3 @@ func TestEndpointOptions(t *testing.T) {
 		})
 	}
 }
-
-func contains(slice []string, item string) bool {
-	for _, s := range slice {
-		if s == item {
-			return true
-		}
-	}
-	return false
-}

pkg/storer/netstore_test.go

@@ -8,6 +8,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"slices"
 	"testing"
 	"time"
 
@@ -52,13 +53,7 @@ func testNetStore(t *testing.T, newStorer func(r retrieval.Interface) (*storer.D
 				for {
 					select {
 					case op := <-lstore.PusherFeed():
-						found := false
-						for _, ch := range chunks {
-							if op.Chunk.Equal(ch) {
-								found = true
-								break
-							}
-						}
+						found := slices.ContainsFunc(chunks, op.Chunk.Equal)
 						if !found {
 							op.Err <- fmt.Errorf("incorrect chunk for push: have %s", op.Chunk.Address())
 							continue
@@ -110,13 +105,7 @@ func testNetStore(t *testing.T, newStorer func(r retrieval.Interface) (*storer.D
 				for {
 					select {
 					case op := <-lstore.PusherFeed():
-						found := false
-						for _, ch := range chunks {
-							if op.Chunk.Equal(ch) {
-								found = true
-								break
-							}
-						}
+						found := slices.ContainsFunc(chunks, op.Chunk.Equal)
 						if !found {
 							op.Err <- fmt.Errorf("incorrect chunk for push: have %s", op.Chunk.Address())
 							continue