fix: test with blocklist streams

Author: martinconic

pkg/p2p/libp2p/connections_test.go

@@ -1073,6 +1073,14 @@ func TestWithBlocklistStreams(t *testing.T) {
 	expectPeersEventually(t, s2)
 	expectPeersEventually(t, s1)
 
+	err = spinlock.Wait(time.Second*5, func() bool {
+		b, _ := s1.Blocklisted(overlay2) // Check if s1 has blocklisted s2
+		return b
+	})
+	if err != nil {
+		t.Fatal("timed out waiting for s1 to blocklist s2")
+	}
+
 	if _, err := s2.Connect(ctx, s1_underlay); err == nil {
 		t.Fatal("expected error when connecting to blocklisted peer")
 	}

pkg/p2p/libp2p/libp2p.go

@@ -1016,15 +1016,6 @@ func (s *Service) Connect(ctx context.Context, addrs []ma.Multiaddr) (address *b
 		return nil, fmt.Errorf("connect full close %w", err)
 	}
 
-	for _, addr := range addrs {
-		pingCtx, cancel := context.WithTimeout(ctx, 2*time.Second)
-		defer cancel()
-		if _, err := s.Ping(pingCtx, addr); err != nil {
-			_ = s.Disconnect(overlay, "peer disconnected immediately after handshake")
-			return nil, p2p.ErrPeerNotFound
-		}
-	}
-
 	if !s.peers.Exists(overlay) {
 		return nil, p2p.ErrPeerNotFound
 	}