fix(api): resolve panic when storage incentives disabled (#5150)

Author: gacevicljubisa

pkg/api/router.go

@@ -191,7 +191,7 @@ func (s *Service) checkRouteAvailability(handler http.Handler) http.Handler {
 func (s *Service) checkSwapAvailability(handler http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if !s.swapEnabled {
-			jsonhttp.NotImplemented(w, "Swap is disabled. This endpoint is unavailable.")
+			jsonhttp.Forbidden(w, "Swap is disabled. This endpoint is unavailable.")
 			return
 		}
 		handler.ServeHTTP(w, r)
@@ -201,7 +201,17 @@ func (s *Service) checkSwapAvailability(handler http.Handler) http.Handler {
 func (s *Service) checkChequebookAvailability(handler http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if !s.chequebookEnabled {
-			jsonhttp.NotImplemented(w, "Chequebook is disabled. This endpoint is unavailable.")
+			jsonhttp.Forbidden(w, "Chequebook is disabled. This endpoint is unavailable.")
+			return
+		}
+		handler.ServeHTTP(w, r)
+	})
+}
+
+func (s *Service) checkStorageIncentivesAvailability(handler http.Handler) http.Handler {
+	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		if s.redistributionAgent == nil {
+			jsonhttp.Forbidden(w, "Storage incentives are disabled. This endpoint is unavailable.")
 			return
 		}
 		handler.ServeHTTP(w, r)
@@ -635,9 +645,12 @@ func (s *Service) mountBusinessDebug() {
 		})),
 	)
 
-	handle("/redistributionstate", jsonhttp.MethodHandler{
-		"GET": http.HandlerFunc(s.redistributionStatusHandler),
-	})
+	handle("/redistributionstate", web.ChainHandlers(
+		s.checkStorageIncentivesAvailability,
+		web.FinalHandler(jsonhttp.MethodHandler{
+			"GET": http.HandlerFunc(s.redistributionStatusHandler),
+		})),
+	)
 
 	handle("/status", jsonhttp.MethodHandler{
 		"GET": web.ChainHandlers(

pkg/api/router_test.go

@@ -281,17 +281,17 @@ func TestEndpointOptions(t *testing.T) {
 				{"/consumed", []string{"GET"}, http.StatusNoContent},
 				{"/consumed/{peer}", []string{"GET"}, http.StatusNoContent},
 				{"/timesettlements", []string{"GET"}, http.StatusNoContent},
-				{"/settlements", nil, http.StatusNotImplemented},
-				{"/settlements/{peer}", nil, http.StatusNotImplemented},
-				{"/chequebook/cheque/{peer}", nil, http.StatusNotImplemented},
-				{"/chequebook/cheque", nil, http.StatusNotImplemented},
-				{"/chequebook/cashout/{peer}", nil, http.StatusNotImplemented},
+				{"/settlements", nil, http.StatusForbidden},
+				{"/settlements/{peer}", nil, http.StatusForbidden},
+				{"/chequebook/cheque/{peer}", nil, http.StatusForbidden},
+				{"/chequebook/cheque", nil, http.StatusForbidden},
+				{"/chequebook/cashout/{peer}", nil, http.StatusForbidden},
 				{"/chequebook/balance", []string{"GET"}, http.StatusNoContent},
 				{"/chequebook/address", []string{"GET"}, http.StatusNoContent},
 				{"/chequebook/deposit", []string{"POST"}, http.StatusNoContent},
 				{"/chequebook/withdraw", []string{"POST"}, http.StatusNoContent},
-				{"/wallet", nil, http.StatusNotImplemented},
-				{"/wallet/withdraw/{coin}", nil, http.StatusNotImplemented},
+				{"/wallet", nil, http.StatusForbidden},
+				{"/wallet/withdraw/{coin}", nil, http.StatusForbidden},
 				{"/stamps", []string{"GET"}, http.StatusNoContent},
 				{"/stamps/{batch_id}", []string{"GET"}, http.StatusNoContent},
 				{"/stamps/{batch_id}/buckets", []string{"GET"}, http.StatusNoContent},
@@ -381,12 +381,12 @@ func TestEndpointOptions(t *testing.T) {
 				{"/chequebook/cheque/{peer}", []string{"GET"}, http.StatusNoContent},
 				{"/chequebook/cheque", []string{"GET"}, http.StatusNoContent},
 				{"/chequebook/cashout/{peer}", []string{"GET", "POST"}, http.StatusNoContent},
-				{"/chequebook/balance", nil, http.StatusNotImplemented},
-				{"/chequebook/address", nil, http.StatusNotImplemented},
-				{"/chequebook/deposit", nil, http.StatusNotImplemented},
-				{"/chequebook/withdraw", nil, http.StatusNotImplemented},
-				{"/wallet", nil, http.StatusNotImplemented},
-				{"/wallet/withdraw/{coin}", nil, http.StatusNotImplemented},
+				{"/chequebook/balance", nil, http.StatusForbidden},
+				{"/chequebook/address", nil, http.StatusForbidden},
+				{"/chequebook/deposit", nil, http.StatusForbidden},
+				{"/chequebook/withdraw", nil, http.StatusForbidden},
+				{"/wallet", nil, http.StatusForbidden},
+				{"/wallet/withdraw/{coin}", nil, http.StatusForbidden},
 				{"/stamps", []string{"GET"}, http.StatusNoContent},
 				{"/stamps/{batch_id}", []string{"GET"}, http.StatusNoContent},
 				{"/stamps/{batch_id}/buckets", []string{"GET"}, http.StatusNoContent},