refactor: max allowed doubling (#5016)

acha-bill · web-flow · commit ac831c165f8d · 2025-02-24T08:34:44.000-05:00
diff --git a/pkg/node/node.go b/pkg/node/node.go
@@ -190,6 +190,7 @@ const (
 	reserveWakeUpDuration         = 15 * time.Minute          // time to wait before waking up reserveWorker
 	reserveMinEvictCount          = 1_000
 	cacheMinEvictCount            = 10_000
+	maxAllowedDoubling            = 1
 )
 
 func NewBee(
@@ -254,9 +255,8 @@ func NewBee(
 		return nil, fmt.Errorf("reserve capacity doubling is only allowed for full nodes")
 	}
 
-	const maxAllowedDoubling = 1
 	if o.ReserveCapacityDoubling < 0 || o.ReserveCapacityDoubling > maxAllowedDoubling {
-		return nil, fmt.Errorf("config reserve capacity doubling has to be between default: 0 and maximum: 1")
+		return nil, fmt.Errorf("config reserve capacity doubling has to be between default: 0 and maximum: %d", maxAllowedDoubling)
 	}
 	var shallowReceiptTolerance = maxAllowedDoubling - o.ReserveCapacityDoubling
 

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,7 @@ const (`
`190`	`190`	`reserveWakeUpDuration = 15 * time.Minute // time to wait before waking up reserveWorker`
`191`	`191`	`reserveMinEvictCount = 1_000`
`192`	`192`	`cacheMinEvictCount = 10_000`
	`193`	`+ maxAllowedDoubling = 1`
`193`	`194`	`)`
`194`	`195`
`195`	`196`	`func NewBee(`
`@@ -254,9 +255,8 @@ func NewBee(`
`254`	`255`	`return nil, fmt.Errorf("reserve capacity doubling is only allowed for full nodes")`
`255`	`256`	`}`
`256`	`257`
`257`		`- const maxAllowedDoubling = 1`
`258`	`258`	`if o.ReserveCapacityDoubling < 0 \|\| o.ReserveCapacityDoubling > maxAllowedDoubling {`
`259`		`- return nil, fmt.Errorf("config reserve capacity doubling has to be between default: 0 and maximum: 1")`
	`259`	`+ return nil, fmt.Errorf("config reserve capacity doubling has to be between default: 0 and maximum: %d", maxAllowedDoubling)`
`260`	`260`	`}`
`261`	`261`	`var shallowReceiptTolerance = maxAllowedDoubling - o.ReserveCapacityDoubling`
`262`	`262`