fix: address some comments

Author: gacevicljubisa

pkg/api/feed.go

@@ -177,12 +177,12 @@ func (s *Service) feedPostHandler(w http.ResponseWriter, r *http.Request) {
 	}
 
 	headers := struct {
-		BatchID         []byte           `map:"Swarm-Postage-Batch-Id" validate:"required"`
-		Pin             bool             `map:"Swarm-Pin"`
-		Deferred        *bool            `map:"Swarm-Deferred-Upload"`
-		Act             bool             `map:"Swarm-Act"`
-		HistoryAddress  swarm.Address    `map:"Swarm-Act-History-Address"`
-		RedundancyLevel redundancy.Level `map:"Swarm-Redundancy-Level"`
+		BatchID         []byte            `map:"Swarm-Postage-Batch-Id" validate:"required"`
+		Pin             bool              `map:"Swarm-Pin"`
+		Deferred        *bool             `map:"Swarm-Deferred-Upload"`
+		Act             bool              `map:"Swarm-Act"`
+		HistoryAddress  swarm.Address     `map:"Swarm-Act-History-Address"`
+		RedundancyLevel *redundancy.Level `map:"Swarm-Redundancy-Level"`
 	}{}
 	if response := s.mapStructure(r.Header, &headers); response != nil {
 		response("invalid header params", logger, w)
@@ -239,7 +239,10 @@ func (s *Service) feedPostHandler(w http.ResponseWriter, r *http.Request) {
 		logger:         logger,
 	}
 
-	rLevel := headers.RedundancyLevel
+	rLevel := redundancy.DefaultLevel
+	if headers.RedundancyLevel != nil {
+		rLevel = *headers.RedundancyLevel
+	}
 
 	l := loadsave.New(s.storer.ChunkStore(), s.storer.Cache(), requestPipelineFactory(r.Context(), putter, false, 0), rLevel)
 	feedManifest, err := manifest.NewDefaultManifest(l, false)

pkg/api/soc.go

@@ -73,7 +73,7 @@ func (s *Service) socUploadHandler(w http.ResponseWriter, r *http.Request) {
 		err        error
 	)
 
-	var rLevel redundancy.Level
+	rLevel := redundancy.DefaultLevel
 	if headers.RLevel != nil {
 		rLevel = *headers.RLevel
 	}

pkg/replicas/getter_soc.go

@@ -101,8 +101,8 @@ func (g *socGetter) Get(ctx context.Context, addr swarm.Address) (ch swarm.Chunk
 			continue
 
 			// getting the addresses in order
-		case so := <-next:
-			if so == nil {
+		case so, ok := <-next:
+			if !ok {
 				next = nil
 				continue
 			}

pkg/replicas/putter_soc.go

@@ -9,6 +9,7 @@ package replicas
 import (
 	"context"
 	"errors"
+	"fmt"
 
 	"github.com/ethersphere/bee/v2/pkg/file/redundancy"
 	"github.com/ethersphere/bee/v2/pkg/storage"
@@ -36,7 +37,7 @@ func (p *socPutter) Put(ctx context.Context, ch swarm.Chunk) error {
 	errs := []error{}
 	// Put base chunk first
 	if err := p.putter.Put(ctx, ch); err != nil {
-		return err
+		return fmt.Errorf("soc putter: put base chunk: %w", err)
 	}
 	if p.rLevel == 0 {
 		return nil

pkg/replicas/replicas.go

@@ -41,10 +41,12 @@ func newReplicator(addr swarm.Address, rLevel redundancy.Level) *replicator {
 	rr := &replicator{
 		addr:   addr.Bytes(),
 		sizes:  redundancy.GetReplicaCounts(),
-		c:      make(chan *replica, 16),
+		c:      make(chan *replica, rLevel.GetReplicaCount()),
 		rLevel: rLevel,
 	}
+
 	go rr.replicas()
+
 	return rr
 }