Skip to content

Commit f732887

Browse files
fix(gsoc): improve logs to print node name when listening (#461)
* fix(gsoc): improve logs to print node name when listening * fix(gsoc): pass nodeName to goroutine
1 parent f801186 commit f732887

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

pkg/check/gsoc/gsoc.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ func run(ctx context.Context, uploadClient *bee.Client, listenClient *bee.Client
125125
logger.Infof("gsoc: socAddress=%s, listner node address=%s", socAddress, addresses.Overlay)
126126

127127
listener := &socListener{}
128-
ch, err := listener.Listen(ctx, listenClient.Host(), socAddress, logger)
128+
ch, err := listener.Listen(ctx, listenClient, socAddress, logger)
129129
if err != nil {
130130
return fmt.Errorf("listen websocket: %w", err)
131131
}
@@ -306,41 +306,41 @@ func (s *socListener) Close() {
306306
close(s.ch)
307307
}
308308

309-
func (s *socListener) Listen(ctx context.Context, host string, addr swarm.Address, logger logging.Logger) (<-chan string, error) {
309+
func (s *socListener) Listen(ctx context.Context, client *bee.Client, addr swarm.Address, logger logging.Logger) (<-chan string, error) {
310310
dialer := &websocket.Dialer{
311311
Proxy: http.ProxyFromEnvironment,
312312
HandshakeTimeout: 45 * time.Second,
313313
}
314314

315-
ws, _, err := dialer.DialContext(ctx, fmt.Sprintf("ws://%s/gsoc/subscribe/%s", host, addr), http.Header{})
315+
ws, _, err := dialer.DialContext(ctx, fmt.Sprintf("ws://%s/gsoc/subscribe/%s", client.Host(), addr), http.Header{})
316316
if err != nil {
317317
return nil, err
318318
}
319319
s.ws = ws
320320
s.ch = make(chan string)
321321
s.listening = true
322322

323-
go func() {
323+
go func(nodeName string) {
324324
for {
325325
select {
326326
case <-ctx.Done():
327327
return
328328
default:
329329
msgType, data, err := ws.ReadMessage()
330330
if err != nil {
331-
logger.Infof("gsoc: websocket error %v", err)
331+
logger.WithField("node", nodeName).Infof("gsoc: websocket error: %v", err)
332332
return
333333
}
334334
if msgType != websocket.BinaryMessage {
335-
logger.Info("gsoc: websocket received non-binary message")
335+
logger.WithField("node", nodeName).Info("gsoc: websocket received non-binary message")
336336
continue
337337
}
338338

339-
logger.Infof("gsoc: websocket received message %s", string(data))
339+
logger.WithField("node", nodeName).Infof("gsoc: websocket received message: %s", string(data))
340340
s.ch <- string(data)
341341
}
342342
}
343-
}()
343+
}(client.Name())
344344

345345
return s.ch, nil
346346
}

0 commit comments

Comments
 (0)