feat: extend manifest integration test#443
Conversation
|
This part of code should be defered when buffer initialized beekeeper/pkg/check/manifest/manifest.go Lines 196 to 198 in 0b91024 It will ensure that io.Writer is properly closed even if error occurs during writing. |
|
One improvement regarding Options: beekeeper/pkg/check/manifest/manifest.go Lines 36 to 46 in 4d02a31 Maybe to put PostageLabel default value to manifest-check, or something like that to distingush it from other batch labels.Maybe this would be nice to do for every check that uses PostageLabel option, to have the check name in it? What do you think @istae ?
Also, MaxPathnameLength shouldn't be less then 2, or it will panic. |
The label can be used strategically in general, because the GetCreateMutableBatch function matches the label, and it can reuse the same batch created before to save on cost and time (by not waiting for a new batch to be created which can take few minutes). |
@istae Would this mean that we can resuse the same batch created with specific check? Or is it ok to use |
If the tests run one by one then it's more optimal to simply reuse the same batch. |
janos
left a comment
There was a problem hiding this comment.
I agree with existing comments and would like to add that the check will be more responsive in certain situations if time.Sleep is replaced with select with cases on ctx.Done and time.After.
Uses feeds to test updates to a website
b25c89a401d9f26811680476619a1eb4a4e189e614bc6161cbfd8b343214917b/assets/styles/styles.css