fix: stream manifest download (#657)

* fix: stream manifest download

* test: update test coverage

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: Cafe137

src/command/manifest/download.ts

@@ -1,6 +1,6 @@
 import { MantarayNode } from '@ethersphere/bee-js'
 import chalk from 'chalk'
-import fs from 'fs'
+import { mkdir, writeFile } from 'fs/promises'
 import { Argument, LeafCommand, Option } from 'furious-commander'
 import { join, parse } from 'path'
 import { exit } from 'process'
@@ -73,9 +73,9 @@ export class Download extends RootCommand implements LeafCommand {
       }
     }
     const parsedForkPath = parse(node.fullPathString)
-    const data = await this.bee.downloadData(node.targetAddress)
 
     if (this.stdout) {
+      const data = await this.bee.downloadData(node.targetAddress)
       process.stdout.write(data.toUtf8())
 
       return
@@ -85,12 +85,14 @@ export class Download extends RootCommand implements LeafCommand {
     const destinationFolder = join(destination, parsedForkPath.dir)
 
     if (!directoryExists(destinationFolder)) {
-      await fs.promises.mkdir(destinationFolder, { recursive: true })
+      await mkdir(destinationFolder, { recursive: true })
     }
 
+    const readStream = await this.bee.downloadReadableData(node.targetAddress)
+    await writeFile(join(destination, node.fullPathString), readStream)
+
     if (!this.stdout && !this.quiet && !this.curl) {
       process.stdout.write(' ' + chalk.green('OK') + '\n')
     }
-    await fs.promises.writeFile(join(destination, node.fullPathString), data.toUint8Array())
   }
 }

test/coverage/coverage-summary.json

@@ -1,4 +1,4 @@
-{"total": {"lines":{"total":2681,"covered":1959,"skipped":0,"pct":73.06},"statements":{"total":2701,"covered":1972,"skipped":0,"pct":73},"functions":{"total":319,"covered":242,"skipped":0,"pct":75.86},"branches":{"total":569,"covered":302,"skipped":0,"pct":53.07},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":100}}
+{"total": {"lines":{"total":2682,"covered":1960,"skipped":0,"pct":73.07},"statements":{"total":2702,"covered":1973,"skipped":0,"pct":73.01},"functions":{"total":319,"covered":242,"skipped":0,"pct":75.86},"branches":{"total":569,"covered":302,"skipped":0,"pct":53.07},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":100}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/application.ts": {"lines":{"total":2,"covered":0,"skipped":0,"pct":0},"functions":{"total":0,"covered":0,"skipped":0,"pct":100},"statements":{"total":2,"covered":0,"skipped":0,"pct":0},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/config.ts": {"lines":{"total":31,"covered":30,"skipped":0,"pct":96.77},"functions":{"total":1,"covered":0,"skipped":0,"pct":0},"statements":{"total":31,"covered":30,"skipped":0,"pct":96.77},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/curl.ts": {"lines":{"total":24,"covered":24,"skipped":0,"pct":100},"functions":{"total":7,"covered":7,"skipped":0,"pct":100},"statements":{"total":25,"covered":25,"skipped":0,"pct":100},"branches":{"total":13,"covered":12,"skipped":0,"pct":92.3}}
@@ -37,7 +37,7 @@
 ,"/home/runner/work/swarm-cli/swarm-cli/src/command/identity/show.ts": {"lines":{"total":33,"covered":27,"skipped":0,"pct":81.81},"functions":{"total":3,"covered":3,"skipped":0,"pct":100},"statements":{"total":33,"covered":27,"skipped":0,"pct":81.81},"branches":{"total":10,"covered":4,"skipped":0,"pct":40}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/command/manifest/add.ts": {"lines":{"total":39,"covered":38,"skipped":0,"pct":97.43},"functions":{"total":3,"covered":3,"skipped":0,"pct":100},"statements":{"total":39,"covered":38,"skipped":0,"pct":97.43},"branches":{"total":11,"covered":10,"skipped":0,"pct":90.9}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/command/manifest/create.ts": {"lines":{"total":17,"covered":16,"skipped":0,"pct":94.11},"functions":{"total":2,"covered":2,"skipped":0,"pct":100},"statements":{"total":17,"covered":16,"skipped":0,"pct":94.11},"branches":{"total":1,"covered":0,"skipped":0,"pct":0}}
-,"/home/runner/work/swarm-cli/swarm-cli/src/command/manifest/download.ts": {"lines":{"total":49,"covered":48,"skipped":0,"pct":97.95},"functions":{"total":4,"covered":4,"skipped":0,"pct":100},"statements":{"total":50,"covered":49,"skipped":0,"pct":98},"branches":{"total":20,"covered":19,"skipped":0,"pct":95}}
+,"/home/runner/work/swarm-cli/swarm-cli/src/command/manifest/download.ts": {"lines":{"total":50,"covered":49,"skipped":0,"pct":98},"functions":{"total":4,"covered":4,"skipped":0,"pct":100},"statements":{"total":51,"covered":50,"skipped":0,"pct":98.03},"branches":{"total":20,"covered":19,"skipped":0,"pct":95}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/command/manifest/index.ts": {"lines":{"total":11,"covered":11,"skipped":0,"pct":100},"functions":{"total":1,"covered":1,"skipped":0,"pct":100},"statements":{"total":11,"covered":11,"skipped":0,"pct":100},"branches":{"total":0,"covered":0,"skipped":0,"pct":100}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/command/manifest/list.ts": {"lines":{"total":42,"covered":40,"skipped":0,"pct":95.23},"functions":{"total":5,"covered":4,"skipped":0,"pct":80},"statements":{"total":43,"covered":41,"skipped":0,"pct":95.34},"branches":{"total":10,"covered":9,"skipped":0,"pct":90}}
 ,"/home/runner/work/swarm-cli/swarm-cli/src/command/manifest/merge.ts": {"lines":{"total":25,"covered":24,"skipped":0,"pct":96},"functions":{"total":2,"covered":2,"skipped":0,"pct":100},"statements":{"total":25,"covered":24,"skipped":0,"pct":96},"branches":{"total":1,"covered":0,"skipped":0,"pct":0}}