-
Notifications
You must be signed in to change notification settings - Fork 31
Description
Can you submit a Pr, looks like we have padding set by default (which your right would cause problems)
Sent from my iPhone
On May 10, 2018, at 12:30 PM, Dave Appleton [email protected] wrote:
ethjs-util
Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.
Before opening a new issue, you may find an answer in already closed issues:
https://github.com/ethjs/ethjs-util/issues?q=is%3Aissue+is%3AclosedIssue Type
[X ] Bug (https://github.com/ethjs/ethjs-util/blob/master/.github/CONTRIBUTING.md#bug-reports)
Feature (https://github.com/ethjs/ethjs-util/blob/master/.github/CONTRIBUTING.md#feature-requests)
DescriptionEthereum declares that hex values should be encoded compactly.
0x0
0x1
0x11are all valid
0x
0x00
0x01are not
This causes problems when this library is used in products that talk to software that adheres more strictly to the standard - e.g. go-ethereum linked code talking to ganache.
This stems from
https://github.com/ethjs/ethjs-util/blob/master/src/index.js#L4-L33
(Add images if possible)
Steps to reproduce
(Add link to a demo on https://jsfiddle.net or similar if possible)
Versions
Node/NPM:
Browser:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Originally posted by @SilentCicero in #6