Skip to content

Commit 5852cd5

Browse files
committed
feat(integration.yaml): use env vars for beacon node URLs
feat: remove exportloopref linter The integration workflow now uses environment variables to configure beacon node URLs, and the exportloopref linter has been removed from the golangci configuration.
1 parent 6379fae commit 5852cd5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/integration.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ jobs:
1616
network: [mainnet]
1717
runs-on: ubuntu-latest
1818
timeout-minutes: 10
19+
env:
20+
MAINNET_BEACON_API_URL: ${{ secrets.MAINNET_BEACON_API_URL }}
21+
HOLESKY_BEACON_API_URL: ${{ secrets.HOLESKY_BEACON_API_URL }}
1922
steps:
2023
- uses: actions/checkout@v3
2124
- name: Print details
@@ -28,5 +31,4 @@ jobs:
2831
with:
2932
consensus: ${{ matrix.consensus }}
3033
network: ${{ matrix.network }}
31-
beacon_node_url: ${{ matrix.network == 'mainnet' && secrets.MAINNET_BEACON_API_URL || secrets.HOLESKY_BEACON_API_URL }}
32-
34+
beacon_node_url: ${{ matrix.network == 'mainnet' && env.MAINNET_BEACON_API_URL || env.HOLESKY_BEACON_API_URL }}

.golangci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ linters:
2424
- dogsled
2525
- dupl
2626
- errcheck
27-
- exportloopref
2827
- goconst
2928
- gocritic
3029
- gofmt

0 commit comments

Comments
 (0)