Skip to content

Commit 035e154

Browse files
committed
Fix collection symbol initialization and update test assertions for ERC721 collection properties
- Corrected the initialization of the collection symbol in `ERC20FixedDenominationManager` to include a trailing comma for clarity. - Updated test assertions in `EthscriptionsTokenTest` to reflect the new collection name and symbol, ensuring consistency with the latest contract changes.
1 parent 4f0811b commit 035e154

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

contracts/src/ERC20FixedDenominationManager.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ contract ERC20FixedDenominationManager is IProtocolHandler {
169169
bytes memory collectionInitCalldata = abi.encodeWithSelector(
170170
ERC721EthscriptionsCollection.initialize.selector,
171171
deployOp.tick, // Collection name
172-
deployOp.tick.upper() // Collection symbol
172+
deployOp.tick.upper(), // Collection symbol
173173
address(this), // Manager owns the collection
174174
ethscriptionId // Collection ID is the deploy ethscription ID
175175
);

contracts/test/EthscriptionsToken.t.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -639,8 +639,8 @@ contract EthscriptionsTokenTest is TestSetup {
639639

640640
// Verify collection properties
641641
ERC721EthscriptionsCollection collection = ERC721EthscriptionsCollection(collectionAddr);
642-
assertEq(collection.name(), "COLL ERC-721");
643-
assertEq(collection.symbol(), "COLL-ERC-721");
642+
assertEq(collection.name(), "COLL");
643+
assertEq(collection.symbol(), "COLL");
644644
assertEq(collection.collectionId(), DEPLOY_TX_HASH);
645645

646646
// Verify collection lookups work

0 commit comments

Comments
 (0)