Validation fixes

Author: RogerPodacter

app/models/validation_result.rb

@@ -9,6 +9,33 @@ class ValidationResult < ApplicationRecord
     where("JSON_EXTRACT(validation_stats, '$.validation_details.expected_creations') > 0 OR JSON_EXTRACT(validation_stats, '$.validation_details.expected_transfers') > 0 OR JSON_EXTRACT(validation_stats, '$.validation_details.storage_checks') > 0")
   }
 
+  def self.delete_successes_older_than(older_than: 6.hours, batch_size: 2_000, sleep_between_batches: 0.3)
+    cutoff =
+      case older_than
+      when ActiveSupport::Duration
+        older_than.ago
+      when Numeric
+        Time.current - older_than
+      when Time
+        older_than
+      else
+        raise ArgumentError, "Unsupported older_than: #{older_than.class}"
+      end
+
+    scope = successful.where('validated_at < ?', cutoff)
+    total_deleted = 0
+
+    scope.in_batches(of: batch_size) do |relation|
+      deleted = relation.delete_all
+      break if deleted.zero?
+
+      total_deleted += deleted
+      sleep(sleep_between_batches) if sleep_between_batches.positive?
+    end
+
+    total_deleted
+  end
+
   # Class methods for validation management
   def self.last_validated_block
     maximum(:l1_block)

app/services/eth_block_importer.rb

@@ -198,19 +198,24 @@ def import_blocks_until_done
 
     begin
       loop do
+        ImportProfiler.start("import_blocks_until_done_loop")
         # Check for validation failures
+        ImportProfiler.start("real_validation_failure_detected")
         if real_validation_failure_detected?
           failed_block = get_validation_failure_block
           logger.error "Import stopped due to validation failure at block #{failed_block}"
           raise ValidationFailureError.new("Validation failure detected at block #{failed_block}")
         end
+        ImportProfiler.stop("real_validation_failure_detected")
 
         # Check if validation is stalled
+        ImportProfiler.start("validation_stalled")
         if validation_stalled?
           current_position = current_max_eth_block_number
           logger.warn "Import paused - validation is behind (current: #{current_position})"
           raise ValidationStalledError.new("Validation stalled - waiting for validation to catch up")
         end
+        ImportProfiler.stop("validation_stalled")
 
         block_number = next_block_to_import
 
@@ -252,6 +257,8 @@ def import_blocks_until_done
       rescue => e
         logger.error "Import error: #{e.message}"
         raise e
+      ensure
+        ImportProfiler.stop("import_blocks_until_done_loop")
       end
     end
   end
@@ -383,9 +390,9 @@ def import_single_block(block_number)
       ValidationJob.perform_later(block_number, l2_block_hashes)
     end
 
-    ImportProfiler.stop("import_single_block")
-
     [imported_ethscriptions_blocks, [eth_block]]
+  ensure
+    ImportProfiler.stop("import_single_block")
   end
 
   def import_next_block
@@ -486,6 +493,8 @@ def cleanup_stale_validation_records
 
   def report_import_stats(blocks_imported_count:, stats_start_time:, stats_start_block:,
                          total_gas_used:, total_transactions:, imported_l2_blocks:, recent_batch_time:)
+    ImportProfiler.start("report_import_stats")
+                         
     elapsed_time = Time.current - stats_start_time
     current_block = current_max_eth_block_number
 
@@ -521,7 +530,6 @@ def report_import_stats(blocks_imported_count:, stats_start_time:, stats_start_b
     if ENV.fetch('VALIDATION_ENABLED').casecmp?('true')
       last_validated = ValidationResult.last_validated_block || 0
       validation_lag = current_block - last_validated
-      validation_stats = ValidationResult.validation_stats(since: 1.hour.ago)
 
       lag_status = case validation_lag
       when 0..5 then "✅ CURRENT"
@@ -530,11 +538,7 @@ def report_import_stats(blocks_imported_count:, stats_start_time:, stats_start_b
       else "🔴 VERY BEHIND"
       end
 
-      if validation_stats[:total] > 0
-        validation_line = "🔍 VALIDATION: #{lag_status} (#{validation_lag} behind) | #{validation_stats[:passed]}/#{validation_stats[:total]} passed (#{validation_stats[:pass_rate]}%)"
-      else
-        validation_line = "🔍 VALIDATION: #{lag_status} (#{validation_lag} behind) | No validations completed yet"
-      end
+      validation_line = "🔍 VALIDATION: #{lag_status} (#{validation_lag} behind)"
     else
       validation_line = "🔍 Validation: DISABLED"
     end
@@ -558,6 +562,7 @@ def report_import_stats(blocks_imported_count:, stats_start_time:, stats_start_b
     if ImportProfiler.enabled?
       logger.info ""
       logger.info "🔍 DETAILED PROFILER STATS:"
+      ImportProfiler.stop("report_import_stats")
       ImportProfiler.report
       ImportProfiler.reset
     end
@@ -567,15 +572,6 @@ def report_import_stats(blocks_imported_count:, stats_start_time:, stats_start_b
 
   public
 
-  def validation_summary
-    return nil unless ENV.fetch('VALIDATION_ENABLED').casecmp?('true')
-
-    stats = ValidationResult.validation_stats(since: 1.hour.ago)
-    return "No validations completed" if stats[:total] == 0
-
-    "#{stats[:passed]}/#{stats[:total]} passed (#{stats[:pass_rate]}%), #{stats[:failed]} failed"
-  end
-
   def shutdown
     @prefetcher&.shutdown
   end

config/derive_ethscriptions_blocks.rb

@@ -135,11 +135,6 @@ module Clockwork
             total_blocks_imported += blocks_imported
 
             puts "[#{Time.now}] Imported #{blocks_imported} blocks (#{initial_block + 1} to #{final_block})"
-
-            # Show validation summary if enabled
-            if ENV.fetch('VALIDATION_ENABLED').casecmp?('true')
-              puts importer.validation_summary
-            end
           else
             # We're caught up
             elapsed = (Time.now - start_time).round(2)

config/recurring.yml

@@ -13,11 +13,17 @@ development:
   clear_solid_queue_finished_jobs:
     command: "SolidQueue::Job.clear_finished_in_batches(sleep_between_batches: 0.3)"
     schedule: every hour at minute 12
+  purge_old_validation_successes:
+    command: "ValidationResult.delete_successes_older_than"
+    schedule: every hour at minute 43
 
 production:
   clear_solid_queue_finished_jobs:
     command: "SolidQueue::Job.clear_finished_in_batches(sleep_between_batches: 0.3)"
     schedule: every hour at minute 12
+  purge_old_validation_successes:
+    command: "ValidationResult.delete_successes_older_than"
+    schedule: every hour at minute 43
 
 # development:
 #   validation_gap_detection:

lib/block_validator.rb

@@ -477,12 +477,36 @@ def verify_ethscription_storage(creation, l1_block_num, block_tag)
   end
 
   def verify_transfer_ownership(transfers, block_tag)
-    # Group transfers by token to get final owner
+    # Replay transfers in deterministic order to determine the true final owner
     final_owners = {}
 
-    transfers.each do |transfer|
+    sorted_transfers = Array(transfers).each_with_index.sort_by do |transfer, original_index|
+      block_number = transfer[:block_number]
+      transaction_index = transfer[:transaction_index]
+
+      if block_number.nil? || transaction_index.nil?
+        raise "Transfer missing ordering metadata: #{transfer.inspect}"
+      end
+
+      log_index = transfer[:event_log_index] || transfer[:log_index]
+
+      [
+        block_number.to_i,
+        transaction_index.to_i,
+        log_index.nil? ? -1 : log_index.to_i, # calldata transfers (no log) happen before events
+        original_index
+      ]
+    end.map { |transfer, _| transfer }
+
+    sorted_transfers.each do |transfer|
       token_id = transfer[:token_id]
-      final_owners[token_id] = transfer[:to]
+      to_address = transfer[:to]
+  
+      if token_id.blank? || to_address.blank?
+        raise "Transfer missing token_id or recipient: #{transfer.inspect}"
+      end
+  
+      final_owners[token_id.downcase] = to_address.downcase
     end
 
     # Verify each token's final owner

lib/tasks/geth.rake

@@ -0,0 +1,6 @@
+namespace :geth do
+  desc "Print the Geth init command"
+  task :init_command => :environment do
+    puts GethDriver.init_command
+  end
+end