Skip to content

Commit 534c6e4

Browse files
committed
fix: monitor filter state syncing
chore: minor const change
1 parent 495a3ea commit 534c6e4

File tree

1 file changed

+10
-34
lines changed

1 file changed

+10
-34
lines changed

clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldFilters.tsx

Lines changed: 10 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const CONFIDENCE_BUCKETS: ConfidenceBucket[] = [
2323
ConfidenceBucket.MEDIUM,
2424
ConfidenceBucket.LOW,
2525
ConfidenceBucket.MANUAL,
26-
];
26+
] as const;
2727

2828
/**
2929
* Build a nested tree structure from flat data category strings.
@@ -276,35 +276,17 @@ export const MonitorFieldFilters = ({
276276
];
277277

278278
// Get current checked keys from LOCAL state
279-
const checkedKeys = useMemo(
280-
() =>
281-
uniq([
282-
...(localResourceStatus ?? []),
283-
...(localDataCategory ?? []),
284-
...(localConfidenceBucket ?? []),
285-
]),
286-
[localResourceStatus, localDataCategory, localConfidenceBucket],
287-
);
279+
const checkedKeys = uniq([
280+
...(localResourceStatus ?? []),
281+
...(localDataCategory ?? []),
282+
...(localConfidenceBucket ?? []),
283+
]);
288284

289285
// Calculate active filters count from APPLIED state (not local)
290-
const activeFiltersCount = useMemo(() => {
291-
let count = 0;
292-
if (resourceStatus) {
293-
// Deduplicate to get accurate count
294-
count += new Set(resourceStatus).size;
295-
}
296-
if (dataCategory) {
297-
// Deduplicate to get accurate count
298-
count += new Set(dataCategory).size;
299-
}
300-
301-
if (confidenceBucket) {
302-
// Deduplicate to get accurate count
303-
count += new Set(confidenceBucket).size;
304-
}
305-
306-
return count;
307-
}, [resourceStatus, dataCategory, confidenceBucket]);
286+
const activeFiltersCount =
287+
new Set(resourceStatus || []).size +
288+
new Set(dataCategory || []).size +
289+
new Set(confidenceBucket || []).size;
308290

309291
const handleCheck = (
310292
checked: React.Key[] | { checked: React.Key[]; halfChecked: React.Key[] },
@@ -401,13 +383,7 @@ export const MonitorFieldFilters = ({
401383
if (open) {
402384
// When popover opens, refetch data categories to ensure they're up-to-date
403385
refetchDatastoreFilters();
404-
return;
405386
}
406-
407-
// When popover closes without applying, reset local state to match applied state
408-
setLocalResourceStatus(resourceStatus);
409-
setLocalConfidenceBucket(confidenceBucket);
410-
setLocalDataCategory(dataCategory);
411387
};
412388

413389
return (

0 commit comments

Comments
 (0)