Skip to content

Commit 8463e1a

Browse files
authored
Fix vendor count in embedded 2nd layer (#5736)
1 parent d759d6d commit 8463e1a

File tree

4 files changed

+6
-1
lines changed

4 files changed

+6
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
3636
- Fixed Bigquery flakey tests. [#5713](https://github.com/ethyca/fides/pull/5713)
3737
- Fixed breadcrumb navigation issues in data catalog view [#5717](https://github.com/ethyca/fides/pull/5717)
3838
- Fixed `window.Fides.experience` of FidesJS to be a merged version of the minimal and full experience. [#5726](https://github.com/ethyca/fides/pull/5726)
39+
- Fixed vendor count template string on FidesJS embedded layer 2 descriptions (#5736)[https://github.com/ethyca/fides/pull/5736]
3940

4041
## [2.54.0](https://github.com/ethyca/fides/compare/2.53.0...2.54.0)
4142

clients/admin-ui/src/features/system/add-multiple-systems/AddMultipleSystems.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ export const AddMultipleSystems = ({ redirectRoute }: Props) => {
263263
successToastParams(
264264
`Successfully added ${
265265
vendorIds.length
266-
} ${systemText.toLocaleLowerCase()}`,
266+
} ${systemText.toLocaleLowerCase()}${vendorIds.length > 1 ? "s" : ""}`,
267267
),
268268
);
269269
}

clients/fides-js/src/components/Overlay.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ const Overlay: FunctionComponent<Props> = ({
258258
isMobile: false,
259259
})
260260
}
261+
onVendorPageClick={onVendorPageClick}
261262
>
262263
{renderModalContent()}
263264
</ConsentContent>

clients/privacy-center/cypress/e2e/consent-banner-tcf.cy.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1526,6 +1526,9 @@ describe("Fides-js TCF", () => {
15261526
stubOptions: { fidesDisableBanner: true },
15271527
demoPageWindowParams: { fides_embed: "true" },
15281528
});
1529+
cy.getByTestId("fides-modal-description").within(() => {
1530+
cy.get(".fides-vendor-count").first().should("have.text", "16");
1531+
});
15291532
checkDefaultExperienceRender();
15301533
});
15311534
});

0 commit comments

Comments
 (0)