Skip to content

Commit a42c0ff

Browse files
HA-426 - Datahub - Make glossary node to use for Data Categories configurable (#5734)
1 parent deef26b commit a42c0ff

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
2323

2424
### Changed
2525
- Added frequency field to DataHubSchema integration config [#5716](https://github.com/ethyca/fides/pull/5716)
26+
- Added glossary_node field to DataHubSchema integration config [#5734](https://github.com/ethyca/fides/pull/5734)
2627
- Added initial support for upcoming "headless" CMP experience type [#5731](https://github.com/ethyca/fides/pull/5731)
2728

2829
### Fixed

src/fides/api/schemas/connection_configuration/connection_secrets_datahub.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ class DatahubSchema(ConnectionConfigSecretsSchema):
3333
description="The frequency at which the integration should run. Defaults to daily.",
3434
default=PeriodicIntegrationFrequency.daily,
3535
)
36+
glossary_node: str = Field(
37+
title="Glossary Node",
38+
description="The glossary node name to use on Datahub for Fides Data Categories. Defaults to FidesDataCategories",
39+
default="FidesDataCategories",
40+
)
3641

3742
_required_components: ClassVar[List[str]] = ["datahub_server_url", "datahub_token"]
3843

tests/ops/api/v1/endpoints/test_connection_config_endpoints.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2036,6 +2036,7 @@ def test_put_datahub_connection_config_secrets(
20362036
"datahub_server_url": "https://datahub.example.com",
20372037
"datahub_token": "test",
20382038
"frequency": "weekly",
2039+
"glossary_node": "FidesDataCategories",
20392040
}
20402041
assert datahub_connection_config_no_secrets.last_test_timestamp is None
20412042
assert datahub_connection_config_no_secrets.last_test_succeeded is None
@@ -2072,6 +2073,7 @@ def test_put_datahub_connection_config_secrets_default_frequency(
20722073
"datahub_server_url": "https://datahub.example.com",
20732074
"datahub_token": "test",
20742075
"frequency": "daily",
2076+
"glossary_node": "FidesDataCategories",
20752077
}
20762078
assert datahub_connection_config_no_secrets.last_test_timestamp is None
20772079
assert datahub_connection_config_no_secrets.last_test_succeeded is None

0 commit comments

Comments
 (0)