-
Notifications
You must be signed in to change notification settings - Fork 1
Description
From fideslang created by adamsachs: IABTechLab#138
Bug Description
Still not 100% sure this is a bug in fideslang, but something seems to have changed with the packaging updates in 1.4.3 that's making our mypy runs in fides complain about our imports of fideslang, if using fideslang>=1.4.3.
We need to get this fixed one way or another (again, the "fix" may turn out to be adjusting something over in the dependent library, e.g. fides!) since it's causing false negatives and CI failures in fides and fidesplus.
Steps to Reproduce
- run
nox -s mypyinfides(orfidesplus)
- also can be noticed in CI failures on
mainoffides, e.g. https://github.com/ethyca/fides/actions/runs/5588801027/jobs/10216115614
Expected behavior
we should be effectively not receiving these errors in our dependent libraries, or we should be effectively suppressing them!
Additional context
This was noticed and discussed first on this draft PR. i figured i'd make a proper ticket out of it now, since it's now causing CI failures on main in both repos.
We can re-ticket over in fides and fidesplus if this is a problem on their side in how they're referencing fideslang now with the new packaging scheme.