Skip to content

issues with mypy typing when importing fideslang #6

@NevilleS

Description

@NevilleS

From fideslang created by adamsachs: IABTechLab#138

Bug Description

Still not 100% sure this is a bug in fideslang, but something seems to have changed with the packaging updates in 1.4.3 that's making our mypy runs in fides complain about our imports of fideslang, if using fideslang>=1.4.3.

We need to get this fixed one way or another (again, the "fix" may turn out to be adjusting something over in the dependent library, e.g. fides!) since it's causing false negatives and CI failures in fides and fidesplus.

Steps to Reproduce

  1. run nox -s mypy in fides (or fidesplus)

Expected behavior

we should be effectively not receiving these errors in our dependent libraries, or we should be effectively suppressing them!

Additional context

This was noticed and discussed first on this draft PR. i figured i'd make a proper ticket out of it now, since it's now causing CI failures on main in both repos.

We can re-ticket over in fides and fidesplus if this is a problem on their side in how they're referencing fideslang now with the new packaging scheme.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions