Skip to content

Commit 183ab8b

Browse files
bkuengdagar
authored andcommitted
control_allocator: avoid default argument for virtual method getEffectivenessMatrix
clang tidy error: /__w/PX4-Autopilot/PX4-Autopilot/src/modules/control_allocator/ActuatorEffectiveness/ActuatorEffectivenessMultirotor.cpp:50:34: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors] ActuatorEffectivenessMultirotor::getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix,
1 parent 563cf61 commit 183ab8b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/modules/control_allocator/ActuatorEffectiveness/ActuatorEffectiveness.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class ActuatorEffectiveness
7777
*
7878
* @return true if updated and matrix is set
7979
*/
80-
virtual bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force = false) = 0;
80+
virtual bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force) = 0;
8181

8282
/**
8383
* Get the actuator trims

src/modules/control_allocator/ActuatorEffectiveness/ActuatorEffectivenessMultirotor.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class ActuatorEffectivenessMultirotor: public ModuleParams, public ActuatorEffec
7575
static int computeEffectivenessMatrix(const MultirotorGeometry &geometry,
7676
matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &effectiveness);
7777

78-
bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force = false) override;
78+
bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force) override;
7979

8080
int numActuators() const override { return _num_actuators; }
8181
private:

src/modules/control_allocator/ActuatorEffectiveness/ActuatorEffectivenessStandardVTOL.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class ActuatorEffectivenessStandardVTOL: public ActuatorEffectiveness
4949
ActuatorEffectivenessStandardVTOL();
5050
virtual ~ActuatorEffectivenessStandardVTOL() = default;
5151

52-
bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force = false) override;
52+
bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force) override;
5353

5454
/**
5555
* Set the current flight phase

src/modules/control_allocator/ActuatorEffectiveness/ActuatorEffectivenessTiltrotorVTOL.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class ActuatorEffectivenessTiltrotorVTOL: public ActuatorEffectiveness
4949
ActuatorEffectivenessTiltrotorVTOL();
5050
virtual ~ActuatorEffectivenessTiltrotorVTOL() = default;
5151

52-
bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force = false) override;
52+
bool getEffectivenessMatrix(matrix::Matrix<float, NUM_AXES, NUM_ACTUATORS> &matrix, bool force) override;
5353

5454
/**
5555
* Set the current flight phase

0 commit comments

Comments
 (0)