Skip to content

Commit e9463bd

Browse files
committed
Removed a few unnecessary copies caused by aslam return values not being respected
1 parent d9b0b23 commit e9463bd

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

algorithms/loopclosure/loop-closure-handler/src/loop-detector-node.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ void LoopDetectorNode::convertFrameToProjectedImageOnlyUsingProvidedLandmarkIds(
152152
static_cast<int>(observed_landmark_ids.size()),
153153
frame.getDescriptorsOfType(feature_type_).cols());
154154

155-
const Eigen::Matrix2Xd& original_measurements =
155+
const Eigen::Block<const Eigen::Matrix2Xd> original_measurements =
156156
frame.getKeypointMeasurementsOfType(feature_type_);
157157
const aslam::VisualFrame::DescriptorsT& original_descriptors =
158158
frame.getDescriptorsOfType(feature_type_);

algorithms/online-map-builders/src/stream-map-builder.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,12 +1081,12 @@ void StreamMapBuilder::notifyExternalFeaturesMeasurementBuffer() {
10811081
if (!queries_.getClosestVertexIdByTimestamp(
10821082
timestamp_ns_measurement, external_features_sync_tolerance_ns_,
10831083
&closest_vertex_id, &delta_ns)) {
1084-
/*LOG(WARNING)
1084+
LOG(WARNING)
10851085
<< "[StreamMapBuilder] Could not attach external features "
10861086
<< "measurement, because the timestamp is not close enough to "
10871087
<< "a vertex in the pose graph (delta = " << delta_ns << "ns > "
10881088
<< external_features_sync_tolerance_ns_
1089-
<< "ns)! timestamp_ns: " << timestamp_ns_measurement << ".";*/
1089+
<< "ns)! timestamp_ns: " << timestamp_ns_measurement << ".";
10901090
continue;
10911091
}
10921092

0 commit comments

Comments
 (0)