Skip to content

Commit 8ea8649

Browse files
Feature/remove cose dependency (#71)
* - remove extra dependency on cose library; * - updated dependency structure;
1 parent 66b2531 commit 8ea8649

File tree

9 files changed

+28
-156
lines changed

9 files changed

+28
-156
lines changed

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ buildscript {
88
}
99

1010
dependencies {
11-
classpath Deps.tools_gradle_android
12-
classpath Deps.tools_kotlin
11+
classpath "com.android.tools.build:gradle:4.1.3"
12+
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.32"
1313

1414
// NOTE: Do not place your application dependencies here; they belong
1515
// in the individual module build.gradle files

buildSrc/.gitignore

Lines changed: 0 additions & 2 deletions
This file was deleted.

buildSrc/build.gradle.kts

Lines changed: 0 additions & 7 deletions
This file was deleted.

buildSrc/src/main/java/AppConfig.kt

Lines changed: 0 additions & 36 deletions
This file was deleted.

buildSrc/src/main/java/Dependencies.kt

Lines changed: 0 additions & 41 deletions
This file was deleted.

buildSrc/src/main/java/Versions.kt

Lines changed: 0 additions & 43 deletions
This file was deleted.

decoder/build.gradle

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@ plugins {
44
}
55

66
android {
7-
compileSdkVersion Config.compileSdk
7+
compileSdkVersion 29
88

99
defaultConfig {
10-
minSdkVersion Config.minSdk
11-
targetSdkVersion Config.targetSdk
12-
versionCode Config.versionCode
13-
versionName Config.versionName
10+
minSdkVersion 21
11+
targetSdkVersion 30
12+
versionCode 1
13+
versionName "1.0.0"
1414

15-
testInstrumentationRunner Config.androidTestInstrumentation
16-
consumerProguardFiles Config.proguardConsumerRules
15+
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
16+
consumerProguardFiles "consumer-rules.pro"
1717
}
1818

1919
buildTypes {
@@ -25,8 +25,8 @@ android {
2525

2626
compileOptions {
2727
coreLibraryDesugaringEnabled = true
28-
sourceCompatibility Config.javaVersion
29-
targetCompatibility Config.javaVersion
28+
sourceCompatibility JavaVersion.VERSION_1_8
29+
targetCompatibility JavaVersion.VERSION_1_8
3030
}
3131

3232
kotlinOptions {
@@ -42,21 +42,21 @@ android {
4242
}
4343

4444
dependencies {
45-
coreLibraryDesugaring Deps.desugar_jdk_libs
45+
coreLibraryDesugaring "com.android.tools:desugar_jdk_libs:1.1.5"
4646

47-
implementation Deps.kotlin_stdlib
48-
implementation Deps.kotlin_reflect
49-
implementation Deps.java_cose
50-
implementation(Deps.json_validation) {
47+
implementation "org.jetbrains.kotlin:kotlin-stdlib:1.4.32"
48+
implementation "org.jetbrains.kotlin:kotlin-reflect:1.4.32"
49+
implementation "com.upokecenter:cbor:4.5.1"
50+
implementation("com.github.java-json-tools:json-schema-validator:2.2.14") {
5151
exclude group: "org.mozilla", module: "rhino"
5252
}
5353

54-
implementation Deps.jackson_cbor
55-
implementation Deps.bouncy_castle
54+
implementation "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.12.3"
55+
implementation "org.bouncycastle:bcpkix-jdk15to18:1.68"
5656

57-
testImplementation Deps.test_junit
58-
testImplementation Deps.test_junit_jupiter_api
59-
testImplementation Deps.test_junit_jupiter_params
60-
testImplementation Deps.test_hamcrest
61-
testRuntimeOnly Deps.test_runtime_only
57+
testImplementation "junit:junit:4.13.1"
58+
testImplementation "org.junit.jupiter:junit-jupiter-api:5.7.1"
59+
testImplementation "org.junit.jupiter:junit-jupiter-params:5.7.1"
60+
testImplementation "org.hamcrest:hamcrest:2.2"
61+
testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:5.7.1"
6262
}

decoder/src/main/java/dgca/verifier/app/decoder/DefaultCertificateDecoder.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222

2323
package dgca.verifier.app.decoder
2424

25-
import COSE.HeaderKeys
2625
import com.upokecenter.cbor.CBORObject
2726
import dgca.verifier.app.decoder.base45.Base45Decoder
2827
import dgca.verifier.app.decoder.cbor.DefaultGreenCertificateMapper
2928
import dgca.verifier.app.decoder.cbor.GreenCertificateMapper
29+
import dgca.verifier.app.decoder.cose.HEADER_KID
3030
import dgca.verifier.app.decoder.cwt.CwtHeaderKeys
3131
import dgca.verifier.app.decoder.model.CoseData
3232
import dgca.verifier.app.decoder.model.GreenCertificate
@@ -86,7 +86,7 @@ class DefaultCertificateDecoder(
8686
val content = messageObject[2].GetByteString()
8787
val rgbProtected = messageObject[0].GetByteString()
8888
val rgbUnprotected = messageObject[1]
89-
val key = HeaderKeys.KID.AsCBOR()
89+
val key = CBORObject.FromObject(HEADER_KID)
9090

9191
if (!CBORObject.DecodeFromBytes(rgbProtected).keys.contains(key)) {
9292
val objunprotected = rgbUnprotected.get(key).GetByteString()

decoder/src/main/java/dgca/verifier/app/decoder/cose/DefaultCoseService.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@
2222

2323
package dgca.verifier.app.decoder.cose
2424

25-
import COSE.HeaderKeys
2625
import com.google.common.primitives.Bytes
2726
import com.upokecenter.cbor.CBORObject
2827
import dgca.verifier.app.decoder.model.CoseData
2928
import dgca.verifier.app.decoder.model.VerificationResult
3029

30+
const val HEADER_KID = 4
31+
3132
/**
3233
* Decodes input according to COSE specification (RFC8152)
3334
*/
@@ -49,7 +50,7 @@ class DefaultCoseService : CoseService {
4950
}
5051

5152
private fun getKid(protectedHeader: ByteArray, unprotectedHeader: CBORObject): CBORObject? {
52-
val key = HeaderKeys.KID.AsCBOR()
53+
val key = CBORObject.FromObject(HEADER_KID)
5354
return if (protectedHeader.isNotEmpty()) {
5455
try {
5556
val kid = CBORObject.DecodeFromBytes(protectedHeader).get(key)

0 commit comments

Comments
 (0)