Merge pull request #4 from eugener/develop

feat(config): add repository configuration management API

Author: eugener

CLAUDE.md

@@ -27,6 +27,12 @@
   - API methods: staged_files(), unstaged_files(), untracked_entries(), files_with_index_status(), files_with_worktree_status()
 - **Staging functionality**: Repository::add(paths), Repository::add_all(), Repository::add_update()
 - **Commit functionality**: Repository::commit(message), Repository::commit_with_author(message, author) - return Hash of created commit
+- **Configuration functionality**: Repository::config() -> RepoConfig - manage git configuration values
+  - RepoConfig::set_user(name, email) -> Result<()> - convenience method for user.name and user.email
+  - RepoConfig::get_user() -> Result<(String, String)> - get user configuration as tuple
+  - RepoConfig::set(key, value) -> Result<()> - set any git configuration value
+  - RepoConfig::get(key) -> Result<String> - get any git configuration value  
+  - RepoConfig::unset(key) -> Result<()> - remove git configuration value
 - **Branch functionality**: Complete branch operations with type-safe API
   - Repository::branches() -> Result<BranchList> - list all branches with comprehensive filtering
   - Repository::current_branch() -> Result<Option<Branch>> - get currently checked out branch
@@ -50,10 +56,10 @@
   - Author struct: name, email, timestamp with Display implementation
   - CommitMessage: subject and optional body parsing
   - CommitDetails: full commit info including file changes and diff stats
-- **Core types**: Hash (in src/types.rs), IndexStatus, WorktreeStatus, FileEntry (in src/commands/status.rs), Branch, BranchList, BranchType (in src/commands/branch.rs), Commit, CommitLog, Author, CommitMessage, CommitDetails, LogOptions (in src/commands/log.rs)
+- **Core types**: Hash (in src/types.rs), IndexStatus, WorktreeStatus, FileEntry (in src/commands/status.rs), Branch, BranchList, BranchType (in src/commands/branch.rs), Commit, CommitLog, Author, CommitMessage, CommitDetails, LogOptions (in src/commands/log.rs), RepoConfig (in src/commands/config.rs)
 - **Utility functions**: git(args, working_dir) -> Result<String>, git_raw(args, working_dir) -> Result<Output>
-- **Command modules**: status.rs, add.rs, commit.rs, branch.rs, log.rs (in src/commands/)
-- **Testing**: 101+ tests covering all functionality with comprehensive edge cases
+- **Command modules**: status.rs, add.rs, commit.rs, branch.rs, log.rs, config.rs (in src/commands/)
+- **Testing**: 106+ tests covering all functionality with comprehensive edge cases
 - Run `cargo fmt && cargo build && cargo test && cargo clippy --all-targets --all-features -- -D warnings` after code changes
 - Make sure all examples are running
 

README.md

@@ -17,11 +17,12 @@ Rustic Git provides a simple, ergonomic interface for common Git operations. It
 - ✅ **Branch management** (create, delete, checkout, list)
 - ✅ **Commit history & log operations** with multi-level API
 - ✅ **Advanced commit querying** with filtering and analysis
+- ✅ **Repository configuration management** with type-safe API
 - ✅ Type-safe error handling with custom GitError enum
 - ✅ Universal `Hash` type for Git objects
 - ✅ **Immutable collections** (Box<[T]>) for memory efficiency
 - ✅ **Const enum conversions** with zero runtime cost
-- ✅ Comprehensive test coverage (101+ tests)
+- ✅ Comprehensive test coverage (106+ tests)
 
 ## Installation
 
@@ -75,6 +76,9 @@ fn main() -> Result<()> {
     // Or stage all changes
     repo.add_all()?;
 
+    // Configure git user for commits
+    repo.config().set_user("Your Name", "[email protected]")?;
+
     // Create a commit
     let hash = repo.commit("Add new features")?;
     println!("Created commit: {}", hash.short());
@@ -259,6 +263,42 @@ Add all tracked files that have been modified (equivalent to `git add -u`).
 repo.add_update()?;
 ```
 
+### Configuration Operations
+
+#### `Repository::config() -> RepoConfig`
+
+Get a configuration manager for the repository to set and get git configuration values.
+
+```rust
+// Configure git user (convenience method)
+repo.config().set_user("Your Name", "[email protected]")?;
+
+// Get user configuration
+let (name, email) = repo.config().get_user()?;
+println!("User: {} <{}>", name, email);
+
+// Set any git configuration value
+repo.config().set("core.autocrlf", "false")?;
+repo.config().set("pull.rebase", "true")?;
+
+// Get any git configuration value
+let autocrlf = repo.config().get("core.autocrlf")?;
+println!("autocrlf setting: {}", autocrlf);
+
+// Remove a configuration value
+repo.config().unset("user.signingkey")?;
+```
+
+#### Configuration Methods
+
+- **`set_user(name, email)`** - Convenience method to set both user.name and user.email
+- **`get_user()`** - Get user configuration as a tuple (name, email)
+- **`set(key, value)`** - Set any git configuration value
+- **`get(key)`** - Get any git configuration value as String
+- **`unset(key)`** - Remove a git configuration value
+
+All configuration operations are scoped to the specific repository.
+
 ### Commit Operations
 
 #### `Repository::commit(message) -> Result<Hash>`
@@ -675,6 +715,13 @@ fn main() -> rustic_git::Result<()> {
     // Create a new repository
     let repo = Repository::init("./my-project", false)?;
 
+    // Configure git user for commits
+    repo.config().set_user("Your Name", "[email protected]")?;
+    
+    // Set some additional repository settings
+    repo.config().set("core.autocrlf", "false")?;
+    repo.config().set("pull.rebase", "true")?;
+
     // Create some files
     fs::write("./my-project/README.md", "# My Project")?;
     fs::create_dir_all("./my-project/src")?;
@@ -748,6 +795,14 @@ fn main() -> rustic_git::Result<()> {
     assert!(status.is_clean());
     println!("Repository is clean!");
 
+    // Display final configuration
+    let (user_name, user_email) = repo.config().get_user()?;
+    println!("Repository configured for: {} <{}>", user_name, user_email);
+    
+    let autocrlf = repo.config().get("core.autocrlf")?;
+    let rebase_setting = repo.config().get("pull.rebase")?;
+    println!("Settings: autocrlf={}, pull.rebase={}", autocrlf, rebase_setting);
+
     Ok(())
 }
 ```
@@ -777,6 +832,9 @@ cargo run --example commit_workflows
 # Branch operations (create, delete, checkout, list)
 cargo run --example branch_operations
 
+# Repository configuration management
+cargo run --example config_operations
+
 # Commit history and log operations with advanced querying
 cargo run --example commit_history
 
@@ -792,6 +850,7 @@ cargo run --example error_handling
 - **`staging_operations.rs`** - Shows all staging methods (add, add_all, add_update) with before/after status comparisons
 - **`commit_workflows.rs`** - Demonstrates commit operations and Hash type methods, including custom authors and hash management
 - **`branch_operations.rs`** - Complete branch management demonstration: create, checkout, delete branches, and BranchList filtering
+- **`config_operations.rs`** - Repository configuration management demonstration: user setup, configuration values, and repository-scoped settings
 - **`commit_history.rs`** - Comprehensive commit history & log operations showing all querying APIs, filtering, analysis, and advanced LogOptions usage
 - **`error_handling.rs`** - Comprehensive error handling patterns showing GitError variants, recovery strategies, and best practices
 
@@ -852,6 +911,7 @@ cargo run --example status_checking
 cargo run --example staging_operations
 cargo run --example commit_workflows
 cargo run --example branch_operations
+cargo run --example config_operations
 cargo run --example commit_history
 cargo run --example error_handling
 ```

examples/config_operations.rs

@@ -0,0 +1,209 @@
+//! Repository Configuration Operations Example
+//!
+//! This example demonstrates the repository configuration management features:
+//! - Setting and getting user configuration
+//! - Managing arbitrary git configuration values
+//! - Repository-scoped configuration operations
+//! - Configuration integration with commit operations
+//!
+//! Run with: cargo run --example config_operations
+
+use rustic_git::{Repository, Result};
+use std::fs;
+use std::path::Path;
+
+fn main() -> Result<()> {
+    println!("Rustic Git - Repository Configuration Operations Example\n");
+
+    // Use a temporary directory for this example
+    let repo_path = "/tmp/rustic_git_config_example";
+
+    // Clean up any previous run
+    if Path::new(repo_path).exists() {
+        fs::remove_dir_all(repo_path).expect("Failed to clean up previous example");
+    }
+
+    println!("Initializing new repository at: {}", repo_path);
+
+    // Initialize a new repository
+    let repo = Repository::init(repo_path, false)?;
+
+    // ==================== USER CONFIGURATION ====================
+
+    println!("\n[CONFIG] Configuring git user settings...");
+
+    // Set user configuration (convenience method)
+    repo.config()
+        .set_user("Alice Developer", "[email protected]")?;
+    println!("Set user configuration");
+
+    // Verify user configuration
+    let (name, email) = repo.config().get_user()?;
+    println!("Current user: {} <{}>", name, email);
+
+    // ==================== GENERAL CONFIGURATION ====================
+
+    println!("\n[CONFIG] Setting repository configuration values...");
+
+    // Set various git configuration values
+    repo.config().set("core.autocrlf", "false")?;
+    repo.config().set("core.ignorecase", "true")?;
+    repo.config().set("pull.rebase", "true")?;
+    repo.config().set("push.default", "simple")?;
+    repo.config().set("branch.autosetupmerge", "always")?;
+
+    println!("Set core configuration values");
+
+    // Get and display configuration values
+    println!("\n[CONFIG] Current repository configuration:");
+
+    let configs = [
+        "core.autocrlf",
+        "core.ignorecase",
+        "pull.rebase",
+        "push.default",
+        "branch.autosetupmerge",
+    ];
+
+    for config_key in &configs {
+        match repo.config().get(config_key) {
+            Ok(value) => println!("  {} = {}", config_key, value),
+            Err(_) => println!("  {} = <not set>", config_key),
+        }
+    }
+
+    // ==================== CONFIGURATION WITH COMMITS ====================
+
+    println!("\n[COMMIT] Testing configuration with commit operations...");
+
+    // Create a test file
+    let test_file_path = format!("{}/test.txt", repo_path);
+    fs::write(
+        &test_file_path,
+        "Hello from rustic-git configuration example!",
+    )?;
+    println!("Created test file: test.txt");
+
+    // Stage the file
+    repo.add(&["test.txt"])?;
+    println!("Staged test.txt");
+
+    // Create a commit (this will use our configured user)
+    let commit_hash = repo.commit("Add test file with configuration example")?;
+    println!("Created commit: {}", commit_hash.short());
+
+    // ==================== CONFIGURATION MODIFICATION ====================
+
+    println!("\n[UPDATE] Modifying configuration values...");
+
+    // Change some configuration values
+    repo.config().set("core.autocrlf", "true")?;
+    repo.config()
+        .set("user.email", "[email protected]")?;
+
+    println!("Updated configuration values");
+
+    // Display updated values
+    let autocrlf = repo.config().get("core.autocrlf")?;
+    let (updated_name, updated_email) = repo.config().get_user()?;
+
+    println!("Updated configuration:");
+    println!("  core.autocrlf = {}", autocrlf);
+    println!("  user: {} <{}>", updated_name, updated_email);
+
+    // ==================== CONFIGURATION REMOVAL ====================
+
+    println!("\n[REMOVE] Removing configuration values...");
+
+    // Remove a configuration value
+    repo.config().unset("branch.autosetupmerge")?;
+    println!("Removed branch.autosetupmerge");
+
+    // Try to get the removed value (should fail)
+    match repo.config().get("branch.autosetupmerge") {
+        Ok(value) => println!("Unexpected: branch.autosetupmerge = {}", value),
+        Err(_) => println!("Confirmed: branch.autosetupmerge is not set"),
+    }
+
+    // ==================== ADVANCED CONFIGURATION ====================
+
+    println!("\n[ADVANCED] Setting advanced configuration...");
+
+    // Set some advanced git configuration
+    repo.config().set("diff.tool", "vimdiff")?;
+    repo.config().set("merge.tool", "vimdiff")?;
+    repo.config().set("alias.st", "status")?;
+    repo.config().set("alias.co", "checkout")?;
+    repo.config().set("alias.br", "branch")?;
+    repo.config().set("alias.ci", "commit")?;
+
+    println!("Set advanced configuration (diff/merge tools and aliases)");
+
+    // Display all custom configuration
+    println!("\n[SUMMARY] Complete repository configuration summary:");
+
+    let all_configs = [
+        ("User", vec![("user.name", ""), ("user.email", "")]),
+        ("Core", vec![("core.autocrlf", ""), ("core.ignorecase", "")]),
+        ("Workflow", vec![("pull.rebase", ""), ("push.default", "")]),
+        ("Tools", vec![("diff.tool", ""), ("merge.tool", "")]),
+        (
+            "Aliases",
+            vec![
+                ("alias.st", ""),
+                ("alias.co", ""),
+                ("alias.br", ""),
+                ("alias.ci", ""),
+            ],
+        ),
+    ];
+
+    for (category, configs) in &all_configs {
+        println!("\n  {}:", category);
+        for (key, _) in configs {
+            match repo.config().get(key) {
+                Ok(value) => println!("    {} = {}", key, value),
+                Err(_) => println!("    {} = <not set>", key),
+            }
+        }
+    }
+
+    // ==================== PRACTICAL EXAMPLE ====================
+
+    println!("\n[TEAM] Practical example: Setting up repository for a team...");
+
+    // Configure repository for team development
+    repo.config().set("user.name", "Team Member")?;
+    repo.config().set("user.email", "[email protected]")?;
+    repo.config().set("core.autocrlf", "input")?;
+    repo.config().set("core.safecrlf", "true")?;
+    repo.config().set("pull.rebase", "true")?;
+    repo.config().set("push.default", "current")?;
+    repo.config().set("init.defaultBranch", "main")?;
+
+    println!("Configured repository for team development");
+
+    // Create another commit with the team configuration
+    fs::write(
+        format!("{}/team.md", repo_path),
+        "# Team Development\n\nThis repository is configured for team development.",
+    )?;
+    repo.add(&["team.md"])?;
+    let team_commit = repo.commit("Add team development documentation")?;
+
+    println!("Created team commit: {}", team_commit.short());
+
+    // Final verification
+    let (final_name, final_email) = repo.config().get_user()?;
+    println!("\n[FINAL] Final repository configuration:");
+    println!("  User: {} <{}>", final_name, final_email);
+    println!("  Repository configured for team development workflow");
+
+    // ==================== CLEANUP ====================
+
+    println!("\n[CLEANUP] Cleaning up...");
+    fs::remove_dir_all(repo_path).expect("Failed to clean up example");
+    println!("Example completed successfully!");
+
+    Ok(())
+}

src/commands/branch.rs

@@ -549,6 +549,11 @@ mod tests {
         // Create a repository with an initial commit
         let repo = Repository::init(test_path, false).unwrap();
 
+        // Configure git user for this repository to enable commits
+        repo.config()
+            .set_user("Test User", "[email protected]")
+            .unwrap();
+
         // Create a test file and commit to have a valid HEAD
         std::fs::write(format!("{}/test.txt", test_path), "test content").unwrap();
         repo.add(&["test.txt"]).unwrap();