Review comments

Author: sdhiray7

persistence-modules/core-java-persistence-4/src/main/java/com/baeldung/sql/MultipleSQLExecution.java

@@ -5,13 +5,10 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import java.util.ArrayList;
+import java.util.List;
 
 public class MultipleSQLExecution {
-    
-    private final Logger logger = LoggerFactory.getLogger(MultipleSQLExecution.class);
 
     private Connection connection;
 
@@ -50,33 +47,27 @@ public boolean callStoredProcedure() throws SQLException {
         }
     }
 
-    public boolean executeMultipleSelectStatements() throws SQLException {
+    public List<User> executeMultipleSelectStatements() throws SQLException {
         String sql = "SELECT * FROM users WHERE email = '[email protected]';" +
                      "SELECT * FROM users WHERE email = '[email protected]';";
 
+        List<User> users = new ArrayList<>();
+
         try (Statement statement = connection.createStatement()) {
-            boolean hasResultSet = statement.execute(sql);
-            // We'll log each record using this loop
+            statement.execute(sql); // Here we execute the multiple queries
+
             do {
-                if (hasResultSet) {
-                    try (ResultSet resultSet = statement.getResultSet()) {
-                        while (resultSet.next()) {
-                            logger.info("User ID: " + resultSet.getInt("id"));
-                            logger.info("Name: " + resultSet.getString("name"));
-                            logger.info("Email: " + resultSet.getString("email"));
-                        }
-                    }
-                } else {
-                    // Here we don't have any update statements. 
-                    // However, if SQL contains update statements the we need to handle update counts gracefully
-                    int updateCount = statement.getUpdateCount();
-                    if (updateCount == -1) {
-                        logger.info("No update counts for this statement.");
+                try (ResultSet resultSet = statement.getResultSet()) {
+                    while (resultSet != null && resultSet.next()) {
+                        int id = resultSet.getInt("id");
+                        String name = resultSet.getString("name");
+                        String email = resultSet.getString("email");
+                        users.add(new User(id, name, email));
                     }
                 }
-            } while (statement.getMoreResults() || statement.getUpdateCount() != -1);
+            } while (statement.getMoreResults());
 
-            return true;
         }
+        return users;
     }
 }

persistence-modules/core-java-persistence-4/src/main/java/com/baeldung/sql/User.java

@@ -0,0 +1,38 @@
+package com.baeldung.sql;
+
+public class User {
+    private int id;
+    private String name;
+    private String email;
+
+    public User(int id, String name, String email) {
+        this.id = id;
+        this.name = name;
+        this.email = email;
+    }
+
+    public int getId() {
+        return id;
+    }
+
+    public void setId(int id) {
+        this.id = id;
+    }
+
+    public String getName() {
+        return name;
+    }
+
+    public void setName(String name) {
+        this.name = name;
+    }
+
+    public String getEmail() {
+        return email;
+    }
+
+    public void setEmail(String email) {
+        this.email = email;
+    }
+}
+

persistence-modules/core-java-persistence-4/src/test/java/com/baeldung/sql/MultipleSQLExecutionLiveTest.java

@@ -8,12 +8,13 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
+import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-// We need to make sure that database user_db is created along with the necessary users table.
-// We have added it in the setup() method.
+// Please note, this test requires a MySQL server running on localhost:3306 with database users_db already created.
+// We have added creation of the table it in the setup() method.
 public class MultipleSQLExecutionLiveTest {
 
     private static Connection connection;
@@ -74,24 +75,22 @@ public void givenStoredProcedure_whenCalling_thenRecordsAreInserted() throws SQL
     }
 
     @Test
-    public void givenMultipleSelectStatements_whenExecuting_thenRecordsAreFetched() throws SQLException {
-        // First, we'll insert data for testing
+    public void givenMultipleSelectStatements_whenExecuting_thenCorrectUsersAreFetched() throws SQLException {
         MultipleSQLExecution execution = new MultipleSQLExecution(connection);
         execution.executeMultipleStatements();
 
-        // Next, we'll execute the select statements
-        boolean result = execution.executeMultipleSelectStatements();
-        assertTrue(result, "The select statements should execute successfully.");
+        List<User> users = execution.executeMultipleSelectStatements();
 
-        // Lastly, we'll verify if the correct records are returned
-        try (Statement statement = connection.createStatement();
-             ResultSet resultSet = statement.executeQuery("SELECT * FROM users WHERE email IN ('[email protected]', '[email protected]')")) {
-            int count = 0;
-            while (resultSet.next()) {
-                count++;
-            }
-            assertEquals(2, count, "There should be two records fetched.");
-        }
+        // Here we verify the correct number of users were fetched
+        assertEquals(2, users.size(), "There should be exactly two users fetched.");
+
+        List<String> fetchedUserNames = users.stream()
+                                             .map(User::getName)
+                                             .toList();
+
+        // Here, we verify that expected users are present
+        List<String> expectedUserNames = List.of("Alice", "Bob");
+        assertTrue(fetchedUserNames.containsAll(expectedUserNames), "Fetched users should match the expected names.");
     }
 }