Skip to content

Commit 6a86db7

Browse files
Sam GardnerSam Gardner
authored andcommitted
BAEL-9376 use givenWhenThen test names
1 parent dea6220 commit 6a86db7

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

testing-modules/junit-5-advanced-3/src/test/java/com/baeldung/enginetestkit/DisplayTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,23 +16,23 @@ public class DisplayTest {
1616
private final Display display = new Display(Platform.DESKTOP, 1000);
1717

1818
@Test
19-
void succeeds() {
19+
void whenCorrect_thenSucceeds() {
2020
assertEquals(1000, display.getHeight());
2121
}
2222

2323
@Test
24-
void fails() {
24+
void whenIncorrect_thenFails() {
2525
assertEquals(500, display.getHeight());
2626
}
2727

2828
@Test
2929
@Disabled("Flakey test needs investigating")
30-
void skips() {
30+
void whenDisabled_thenSkips() {
3131
assertEquals(999, display.getHeight());
3232
}
3333

3434
@Test
35-
void aborts() {
35+
void whenAssumptionsFail_thenAborts() {
3636
assumeTrue(display.getPlatform() == Platform.MOBILE, "test only runs for mobile");
3737
}
3838

testing-modules/junit-5-advanced-3/src/test/java/com/baeldung/enginetestkit/EngineTestKitDiscoveryUnitTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
public class EngineTestKitDiscoveryUnitTest {
2323

2424
@Test
25-
void verifyTestEngineDiscovery() {
25+
void givenJunitJupiterEngine_whenRunningTestSuite_thenTestsAreDiscovered() {
2626
EngineDiscoveryResults results = EngineTestKit.engine("junit-jupiter")
2727
.selectors(selectClass(DisplayTest.class))
2828
.discover();
@@ -32,7 +32,7 @@ void verifyTestEngineDiscovery() {
3232
}
3333

3434
@Test
35-
void verifyVintageDiscovery() {
35+
void givenJunitVintageEngine_whenRunningTestSuite_thenTestsAreDiscovered() {
3636
EngineDiscoveryResults results = EngineTestKit.engine("junit-vintage")
3737
.selectors(selectClass(DisplayTest.class))
3838
.discover();
@@ -41,7 +41,7 @@ void verifyVintageDiscovery() {
4141
}
4242

4343
@Test
44-
void verifyHighLevelTestStats() {
44+
void givenTestSuite_whenRunningAllTests_thenCollectHighLevelStats() {
4545
EngineTestKit
4646
.engine("junit-jupiter")
4747
.selectors(selectClass(DisplayTest.class))
@@ -52,29 +52,29 @@ void verifyHighLevelTestStats() {
5252
}
5353

5454
@Test
55-
void verifyTestAbortion() {
55+
void givenTestSuite_whenRunningTestThatAborts_thenCollectDetailedStats() {
5656
Events testEvents = EngineTestKit
5757
.engine("junit-jupiter")
58-
.selectors(selectMethod(DisplayTest.class, "aborts"))
58+
.selectors(selectMethod(DisplayTest.class, "whenAssumptionsFail_thenAborts"))
5959
.execute()
6060
.testEvents();
6161

6262
testEvents.assertThatEvents()
63-
.haveExactly(1, event(test("aborts"),
63+
.haveExactly(1, event(test("whenAssumptionsFail_thenAborts"),
6464
abortedWithReason(instanceOf(TestAbortedException.class),
6565
message(message -> message.contains("test only runs for mobile")))));
6666
}
6767

6868
@Test
69-
void verifyTestFailure() {
69+
void givenTestSuite_whenRunningTestThatFails_thenCollectDetailedStats() {
7070
Events testEvents = EngineTestKit
7171
.engine("junit-jupiter")
72-
.selectors(selectMethod(DisplayTest.class, "fails"))
72+
.selectors(selectMethod(DisplayTest.class, "whenIncorrect_thenFails"))
7373
.execute()
7474
.testEvents();
7575

7676
testEvents.assertThatEvents()
77-
.haveExactly(1, event(test("fails"),
77+
.haveExactly(1, event(test("whenIncorrect_thenFails"),
7878
finishedWithFailure(instanceOf(AssertionFailedError.class))));
7979
}
8080

0 commit comments

Comments
 (0)