Skip to content

Commit bee0e91

Browse files
committed
BAEL-8140: undo micrometer changes
1 parent bc508f7 commit bee0e91

File tree

3 files changed

+3
-64
lines changed

3 files changed

+3
-64
lines changed

spring-boot-modules/spring-boot-3-observation/src/main/java/com/baeldung/micrometer/tags/Application.java

Lines changed: 3 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,14 @@
33
import org.springframework.boot.SpringApplication;
44
import org.springframework.boot.autoconfigure.SpringBootApplication;
55
import org.springframework.context.annotation.Bean;
6-
import org.springframework.expression.Expression;
7-
import org.springframework.expression.ExpressionParser;
8-
import org.springframework.expression.spel.SpelParserConfiguration;
9-
import org.springframework.expression.spel.standard.SpelExpressionParser;
10-
import org.springframework.expression.spel.support.SimpleEvaluationContext;
11-
import org.springframework.expression.spel.support.StandardEvaluationContext;
126

13-
import io.micrometer.common.annotation.ValueExpressionResolver;
147
import io.micrometer.core.aop.CountedAspect;
158
import io.micrometer.core.aop.CountedMeterTagAnnotationHandler;
169
import io.micrometer.core.aop.MeterTagAnnotationHandler;
1710
import io.micrometer.core.aop.TimedAspect;
1811

1912
@SpringBootApplication
20-
public class Application {
13+
class Application {
2114

2215
public static void main(String[] args) {
2316
SpringApplication.run(Application.class, args);
@@ -34,32 +27,10 @@ public MeterTagAnnotationHandler meterTagAnnotationHandler() {
3427
public CountedAspect countedAspect() {
3528
CountedAspect aspect = new CountedAspect();
3629
CountedMeterTagAnnotationHandler tagAnnotationHandler = new CountedMeterTagAnnotationHandler(
37-
aClass -> o -> new SpelValueExpressionResolver().resolve(o.toString(), null),
38-
aClass -> new SpelValueExpressionResolver());
30+
aClass -> Object::toString,
31+
aClass -> (exp, param) -> "");
3932
aspect.setMeterTagAnnotationHandler(tagAnnotationHandler);
4033
return aspect;
4134
}
4235

43-
public static class SpelValueExpressionResolver implements ValueExpressionResolver {
44-
45-
@Override
46-
public String resolve(String expression, Object parameter) {
47-
try {
48-
SpelParserConfiguration config = new SpelParserConfiguration(true, true);
49-
StandardEvaluationContext context = new StandardEvaluationContext(parameter);
50-
51-
ExpressionParser expressionParser = new SpelExpressionParser(config);
52-
return expressionParser.parseExpression(expression)
53-
.getValue(context, String.class);
54-
55-
// ExpressionParser expressionParser = new SpelExpressionParser();
56-
// Expression expressionToEvaluate = expressionParser.parseExpression(expression);
57-
// return expressionToEvaluate.getValue(parameter, String.class);
58-
}
59-
catch (Exception ex) {
60-
ex.printStackTrace(); // todo: proper logging
61-
}
62-
return String.valueOf(parameter);
63-
}
64-
}
6536
}

spring-boot-modules/spring-boot-3-observation/src/main/java/com/baeldung/micrometer/tags/dummy/DummyService.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,14 @@
11
package com.baeldung.micrometer.tags.dummy;
22

3-
import java.math.BigDecimal;
43
import java.util.concurrent.ThreadLocalRandom;
54

65
import org.slf4j.Logger;
76
import org.slf4j.LoggerFactory;
87
import org.springframework.stereotype.Service;
98

10-
import com.baeldung.micrometer.tags.Application;
11-
129
import io.micrometer.core.annotation.Counted;
1310
import io.micrometer.core.annotation.Timed;
1411
import io.micrometer.core.aop.MeterTag;
15-
import io.micrometer.core.aop.MeterTags;
1612
import io.micrometer.core.instrument.Counter;
1713
import io.micrometer.core.instrument.Meter;
1814
import io.micrometer.core.instrument.MeterRegistry;
@@ -69,23 +65,6 @@ public String buzz(@MeterTag("device.type") String device) {
6965
return invokeSomeLogic();
7066
}
7167

72-
@Counted(value = "fizz")
73-
public String fizz(
74-
@MeterTag(key = "id", expression = "#order.id")
75-
@MeterTag(key = "other.id", expression = "#order.otherOrder.id")
76-
@MeterTag(key = "math", expression = "20 - 1")
77-
@MeterTag(key = "total", expression = "#order.total")
78-
@MeterTag(key = "other.total", expression = "#order.otherOrder.total")
79-
@MeterTag(key = "total.group", expression = "#order.total > 50 ? 'high' : 'low'")
80-
Order order
81-
) {
82-
log.info("fizz({})", order);
83-
return invokeSomeLogic();
84-
}
85-
86-
public record Order(int id, int total, Order otherOrder) {
87-
}
88-
8968
private String invokeSomeLogic() {
9069
long sleepMs = ThreadLocalRandom.current()
9170
.nextInt(0, 100);

spring-boot-modules/spring-boot-3-observation/src/main/java/com/baeldung/micrometer/tags/dummy/DummyStartupListener.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
package com.baeldung.micrometer.tags.dummy;
22

33
import java.util.List;
4-
import java.util.concurrent.ThreadLocalRandom;
54
import java.util.stream.IntStream;
65

76
import org.springframework.boot.context.event.ApplicationReadyEvent;
87
import org.springframework.context.event.EventListener;
98
import org.springframework.stereotype.Component;
109

11-
import com.baeldung.micrometer.tags.dummy.DummyService.Order;
12-
1310
@Component
1411
class DummyStartupListener {
1512

@@ -27,17 +24,9 @@ void sendRequests() {
2724
service.foo(deviceType);
2825
service.bar(deviceType);
2926
service.buzz(deviceType);
30-
service.fizz(
31-
new Order(randomInt(), randomInt(),
32-
new Order(randomInt(), randomInt(), null)));
3327
});
3428
}
3529

36-
int randomInt() {
37-
return ThreadLocalRandom.current()
38-
.nextInt(1, 100);
39-
}
40-
4130
DummyStartupListener(DummyService service) {
4231
this.service = service;
4332
}

0 commit comments

Comments
 (0)