Skip to content

Commit c4c495a

Browse files
committed
JAVA-41505: Fixes made for LoginFieldsFullIntegrationTest and LoginFieldsSimpleIntegrationTest
1 parent 9659791 commit c4c495a

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

spring-security-modules/spring-security-web-login-2/src/main/java/com/baeldung/loginextrafieldscustom/SecurityConfig.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,11 @@
1212
import org.springframework.security.config.annotation.web.configurers.AbstractHttpConfigurer;
1313
import org.springframework.security.crypto.password.PasswordEncoder;
1414
import org.springframework.security.web.SecurityFilterChain;
15+
import org.springframework.security.web.authentication.SavedRequestAwareAuthenticationSuccessHandler;
1516
import org.springframework.security.web.authentication.SimpleUrlAuthenticationFailureHandler;
1617
import org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter;
18+
import org.springframework.security.web.context.HttpSessionSecurityContextRepository;
19+
import org.springframework.security.web.savedrequest.HttpSessionRequestCache;
1720

1821
@EnableWebSecurity
1922
@PropertySource("classpath:/application-extrafields.properties")
@@ -56,6 +59,8 @@ public CustomAuthenticationFilter authenticationFilter(AuthenticationManager aut
5659
CustomAuthenticationFilter filter = new CustomAuthenticationFilter();
5760
filter.setAuthenticationManager(authenticationManager);
5861
filter.setAuthenticationFailureHandler(failureHandler());
62+
filter.setAuthenticationSuccessHandler(new SavedRequestAwareAuthenticationSuccessHandler());
63+
filter.setSecurityContextRepository(new HttpSessionSecurityContextRepository());
5964
return filter;
6065
}
6166

spring-security-modules/spring-security-web-login-2/src/main/java/com/baeldung/loginextrafieldssimple/SecurityConfig.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
1010
import org.springframework.security.config.annotation.web.configurers.AbstractHttpConfigurer;
1111
import org.springframework.security.web.SecurityFilterChain;
12+
import org.springframework.security.web.authentication.SavedRequestAwareAuthenticationSuccessHandler;
1213
import org.springframework.security.web.authentication.SimpleUrlAuthenticationFailureHandler;
1314
import org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter;
15+
import org.springframework.security.web.context.HttpSessionSecurityContextRepository;
1416

1517
@EnableWebSecurity
1618
@PropertySource("classpath:/application-extrafields.properties")
@@ -46,6 +48,8 @@ public SimpleAuthenticationFilter authenticationFilter(AuthenticationManager aut
4648
SimpleAuthenticationFilter filter = new SimpleAuthenticationFilter();
4749
filter.setAuthenticationManager(authenticationManager);
4850
filter.setAuthenticationFailureHandler(failureHandler());
51+
filter.setAuthenticationSuccessHandler(new SavedRequestAwareAuthenticationSuccessHandler());
52+
filter.setSecurityContextRepository(new HttpSessionSecurityContextRepository());
4953
return filter;
5054
}
5155

spring-security-modules/spring-security-web-login-2/src/test/java/com/baeldung/loginextrafields/LoginFieldsFullIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public void givenAccessSecuredResource_whenAuthenticated_thenAuthHasExtraFields(
5252
.session(session)
5353
.with(csrf()))
5454
.andExpect(status().is3xxRedirection())
55-
.andExpect(redirectedUrlPattern("**/user/index"))
55+
.andExpect(redirectedUrlPattern("**/user/index?continue"))
5656
.andReturn();
5757

5858
mockMvc.perform(securedResourceAccess.session(session))

spring-security-modules/spring-security-web-login-2/src/test/java/com/baeldung/loginextrafields/LoginFieldsSimpleIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public void givenAccessSecuredResource_whenAuthenticated_thenAuthHasExtraFields(
5252
.session(session)
5353
.with(csrf()))
5454
.andExpect(status().is3xxRedirection())
55-
.andExpect(redirectedUrlPattern("**/user/index"))
55+
.andExpect(redirectedUrlPattern("**/user/index?continue"))
5656
.andReturn();
5757

5858
mockMvc.perform(securedResourceAccess.session(session))

0 commit comments

Comments
 (0)