BAEL-8055, Packed Repeated Fields in Protobuf in Java

Author: parthiv39731

grpc/src/main/java/com/baeldung/grpc/repeated/OrderService.java

@@ -12,20 +12,20 @@ public class OrderService extends OrderServiceGrpc.OrderServiceImplBase {
     private static final Logger logger = LoggerFactory.getLogger(OrderService.class);
 
     @Override
-    public void createOrder(UnPackedOrder unpackedOrder, StreamObserver<UnPackedOrder> responseObserver) {
+    public void createOrder(UnpackedOrder unpackedOrder, StreamObserver<UnpackedOrder> responseObserver) {
         List<Integer> productIds = unpackedOrder.getProductIdsList();
         if(validateProducts(productIds)) {
             int orderID = insertOrder(unpackedOrder);
             logger.info("Order {} created successfully", orderID);
-            UnPackedOrder createdUnPackedOrder = UnPackedOrder.newBuilder(unpackedOrder)
+            UnpackedOrder createdUnpackedOrder = UnpackedOrder.newBuilder(unpackedOrder)
                 .setOrderId(orderID)
                 .build();
-            responseObserver.onNext(createdUnPackedOrder);
+            responseObserver.onNext(createdUnpackedOrder);
             responseObserver.onCompleted();
         }
     }
 
-    private int insertOrder(UnPackedOrder unpackedOrder) {
+    private int insertOrder(UnpackedOrder unpackedOrder) {
         return new Random().nextInt(100);
     }
 

grpc/src/main/proto/repeated.proto

@@ -8,11 +8,11 @@ message PackedOrder {
   repeated int32 productIds = 2 [packed = true];
 }
 
-message UnPackedOrder {
+message UnpackedOrder {
   int32 orderId = 1;
   repeated int32 productIds = 2 [packed = false];
 }
 
 service OrderService {
-  rpc createOrder(UnPackedOrder) returns (UnPackedOrder){}
+  rpc createOrder(UnpackedOrder) returns (UnpackedOrder){}
 }

grpc/src/test/java/com/baeldung/grpc/repeated/ProtobufPackedFieldUnitTest.java

@@ -37,8 +37,8 @@ public class ProtobufPackedFieldUnitTest {
     @AfterAll
     static void clean() {
         File packedFile = new File(FOLDER_TO_WRITE_OBJECTS + "packed_order.bin");
-        File unPackedFile = new File(FOLDER_TO_WRITE_OBJECTS + "unpacked_order.bin");
-        if (packedFile.delete() && unPackedFile.delete()) {
+        File unpackedFile = new File(FOLDER_TO_WRITE_OBJECTS + "unpacked_order.bin");
+        if (packedFile.delete() && unpackedFile.delete()) {
             logger.info("files {} and {} deleted successfully", "packed_order.bin", "unpacked_order.bin");
         }
     }
@@ -64,26 +64,26 @@ void setup() throws IOException {
     }
 
     @Test
-    void whenUnPackedRepeatedProductIds_thenCreateUnPackedOrderAndInvokeRPC() {
-        UnPackedOrder.Builder unPackedOrderBuilder = UnPackedOrder.newBuilder();
-        unPackedOrderBuilder.setOrderId(1);
-        Arrays.stream(fetchProductIds()).forEach(unPackedOrderBuilder::addProductIds);
-        UnPackedOrder unPackedOrderRequest = unPackedOrderBuilder.build();
+    void whenUnpackedRepeatedProductIds_thenCreateUnpackedOrderAndInvokeRPC() {
+        UnpackedOrder.Builder unpackedOrderBuilder = UnpackedOrder.newBuilder();
+        unpackedOrderBuilder.setOrderId(1);
+        Arrays.stream(fetchProductIds()).forEach(unpackedOrderBuilder::addProductIds);
+        UnpackedOrder unpackedOrderRequest = unpackedOrderBuilder.build();
 
-        UnPackedOrder unPackedOrderResponse = orderClientStub.createOrder(unPackedOrderRequest);
+        UnpackedOrder unpackedOrderResponse = orderClientStub.createOrder(unpackedOrderRequest);
 
-        assertInstanceOf(Integer.class, unPackedOrderResponse.getOrderId());
+        assertInstanceOf(Integer.class, unpackedOrderResponse.getOrderId());
     }
 
     @Test
-    void whenSerializeUnPackedOrderAndPackedOrderObject_thenSizeofPackedOrderObjectIsLess() throws IOException {
-        UnPackedOrder.Builder unPackedOrderBuilder = UnPackedOrder.newBuilder();
-        unPackedOrderBuilder.setOrderId(1);
-        Arrays.stream(fetchProductIds()).forEach(unPackedOrderBuilder::addProductIds);
-        UnPackedOrder unPackedOrder = unPackedOrderBuilder.build();
-        String unPackedOrderObjFileName = FOLDER_TO_WRITE_OBJECTS + "unpacked_order.bin";
+    void whenSerializeUnpackedOrderAndPackedOrderObject_thenSizeofPackedOrderObjectIsLess() throws IOException {
+        UnpackedOrder.Builder unpackedOrderBuilder = UnpackedOrder.newBuilder();
+        unpackedOrderBuilder.setOrderId(1);
+        Arrays.stream(fetchProductIds()).forEach(unpackedOrderBuilder::addProductIds);
+        UnpackedOrder unpackedOrder = unpackedOrderBuilder.build();
+        String unpackedOrderObjFileName = FOLDER_TO_WRITE_OBJECTS + "unpacked_order.bin";
 
-        serializeObject(unPackedOrderObjFileName, unPackedOrder);
+        serializeObject(unpackedOrderObjFileName, unpackedOrder);
 
         PackedOrder.Builder packedOrderBuilder = PackedOrder.newBuilder();
         packedOrderBuilder.setOrderId(1);
@@ -93,7 +93,7 @@ void whenSerializeUnPackedOrderAndPackedOrderObject_thenSizeofPackedOrderObjectI
 
         serializeObject(packedOrderObjFileName, packedOrder);
 
-        long sizeOfUnpackedOrderObjectFile = getFileSize(unPackedOrderObjFileName);
+        long sizeOfUnpackedOrderObjectFile = getFileSize(unpackedOrderObjFileName);
         long sizeOfPackedOrderObjectFile = getFileSize(packedOrderObjFileName);
         long sizeReductionPercentage = (sizeOfUnpackedOrderObjectFile - sizeOfPackedOrderObjectFile) * 100/sizeOfUnpackedOrderObjectFile;
         logger.info("Packed field saved {}% over unpacked field", sizeReductionPercentage);