Skip to content

Commit 0bd1b12

Browse files
fix: remove redundant constructor parameter
1 parent 80daa1f commit 0bd1b12

File tree

3 files changed

+2
-24
lines changed

3 files changed

+2
-24
lines changed

src/EulerSwap.sol

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {EVCUtil} from "evc/utils/EVCUtil.sol";
1010

1111
contract EulerSwap is IEulerSwap, EVCUtil {
1212
struct Params {
13-
address evc;
1413
address vault0;
1514
address vault1;
1615
address myAccount;
@@ -75,14 +74,11 @@ contract EulerSwap is IEulerSwap, EVCUtil {
7574
status = 1;
7675
}
7776

78-
constructor(Params memory params, CurveParams memory curveParams) EVCUtil(params.evc) {
77+
constructor(Params memory params, CurveParams memory curveParams) EVCUtil(IEVault(params.vault0).EVC()) {
7978
// EulerSwap params
8079

8180
require(params.fee < 1e18, BadFee());
82-
83-
address vault0Evc = IEVault(params.vault0).EVC();
84-
require(vault0Evc == IEVault(params.vault1).EVC(), DifferentEVC());
85-
require(vault0Evc == params.evc, DifferentEVC());
81+
require(IEVault(params.vault0).EVC() == IEVault(params.vault1).EVC(), DifferentEVC());
8682

8783
address asset0Addr = IEVault(params.vault0).asset();
8884
address asset1Addr = IEVault(params.vault1).asset();

test/EulerSwapTest.t.sol

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,6 @@ contract EulerSwapTest is EulerSwapTestBase {
1212
eulerSwap = createEulerSwap(50e18, 50e18, 0, 1e18, 1e18, 0.4e18, 0.85e18);
1313
}
1414

15-
function test_different_EVC() public {
16-
vm.expectRevert(EulerSwap.DifferentEVC.selector);
17-
18-
new EulerSwap(
19-
EulerSwap.Params({
20-
evc: address(makeAddr("RANDOM_EVC")),
21-
vault0: address(eTST),
22-
vault1: address(eTST2),
23-
myAccount: holder,
24-
debtLimit0: 50e18,
25-
debtLimit1: 50e18,
26-
fee: 0
27-
}),
28-
EulerSwap.CurveParams({priceX: 1e18, priceY: 1e18, concentrationX: 4e18, concentrationY: 0.85e18})
29-
);
30-
}
31-
3215
function test_basicSwap_exactIn() public monotonicHolderNAV {
3316
uint256 amountIn = 1e18;
3417
uint256 amountOut =

test/EulerSwapTestBase.t.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ contract EulerSwapTestBase is EVaultTestBase {
147147
returns (EulerSwap.Params memory)
148148
{
149149
return EulerSwap.Params({
150-
evc: address(evc),
151150
vault0: address(eTST),
152151
vault1: address(eTST2),
153152
myAccount: holder,

0 commit comments

Comments
 (0)