Skip to content

Commit 4334265

Browse files
committed
note invalidated salt
1 parent e269474 commit 4334265

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

docs/audits/EulerSwapHook_Audit_Scope.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,12 @@ The scope of audit involves a re-audit of EulerSwap, primarily `src/`:
5050

5151
Due to technical requirements, EulerSwapHook must take the input token from PoolManager and deposit it into Euler Vaults. It will appear that EulerSwapHook can only support input sizes of `IERC20.balanceOf(PoolManager)`. However swap routers can pre-emptively send input tokens (from user wallet to PoolManager) prior to calling `poolManager.swap` to get around this limitation.
5252

53-
An example `test/utils/MinimalRouter.sol` is provided as an example.
53+
An example `test/utils/MinimalRouter.sol` is provided as an example.
54+
55+
### Invalidated Salts
56+
57+
Uniswap v4 Hooks encode their behaviors within the address, requiring deployers to mine salts for a particular address pattern. Because constructor arguments influence the precomputed address during the salt-finding process, governance may accidentally invalidate a discovered salt by updating the protocol fee.
58+
59+
The EulerSwapFactory passes a protocol fee and protocol fee recipient to a EulerSwap instance (hook). If governance were modify either values between salt-discovery and EulerSwap deployment, the deployment would fail.
60+
61+
This scenario is unlikely to happen as we do not expect protocol fee parameters to change; as well, governance can pre-emptively warn deployers of the parameter change.

0 commit comments

Comments
 (0)