Skip to content

Commit bbfa037

Browse files
committed
todo
1 parent 6323463 commit bbfa037

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

TODO

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,18 @@
1-
! Don't make quotes that would cause a swap to fail if supply/borrow caps exceeded
2-
* Better revert messages when a swap fails due to maglev debt-limit/vault utilisation/etc
3-
* currently it's an arithmetic underflow
1+
* Better revert messages when a swap fails due to debt-limit/vault utilisation/etc
2+
* currently they are errors thrown by the vaults or arithmetic underflows
43

54

65
TESTING
76

87
* when exchange rate in vaults != 1
9-
* uniswap callback, flash swaps
10-
* hitting reserve/utilisation limits
11-
* AssetsOutOfOrderOrEqual
128

139

1410
MISC
1511

1612
? A really small swap could fail because deposit() results in 0 shares, which causes EVK to revert. Call convertToShares() first? Seems like overkill...
17-
? permit2 instead of regular approval: measure gas savings
1813
* Improve the efficiency of on-chain quoting
1914
* Probably necessary for supporting non-zero slippage swaps
20-
* Use unchecked math in verify() (needs careful boundary analysis)
21-
* Closed-form quoting solutions
15+
* Use fInverse() Closed-form quoting solutions
2216
* "Range hints" for the binary search
2317

2418

@@ -34,7 +28,3 @@ IDEAS
3428
* Could current reserves be calculated dynamically based on balances/debts/debt limits?
3529
* I guess you would lose a chunk of interest to arbitrage
3630
* Donation attacks?
37-
* What can we do to make this easily integrated with aggregators/MEV bots/etc?
38-
* How to handle a discovery/tracking of the different Maglev instances?
39-
? Factory? Registry? Maybe a fake factory that reads the actually installed operators from a set of addresses?
40-
? Transparent proxy so a Maglev address can stay constant

0 commit comments

Comments
 (0)