Skip to content

Commit cc0bfcf

Browse files
committed
todo items
1 parent 0e984f1 commit cc0bfcf

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

TODO

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,16 @@
22
* reserve change on each swap
33
! Better revert messages when a swap cannot be satisifed due to debt-limit/utilisation/etc
44
* currently it's an arithmetic underflow
5+
! Don't make quotes that would cause a swap to fail due to supply or borrow caps
6+
! Use `myDebt() == 0` condition for disabling controller: more accurate
7+
! In _computeQuote() use vault.cash() method instead of token.balanceOf() otherwise donations could cause quoted swaps to fail
8+
! In _computeQuote(), exactOut swaps should verify the *amount* (not quote) is withdrawable
59
* ConstantSum: incorporate price multipliers in quote methods
610
* natspec
711
* permit2 instead of regular approval: measure gas savings
12+
* in constructor, check the two vaults have the correct EVC() return value
13+
* maybe even that they were created by the EVK factory?
14+
? a really small swap could fail because deposit() results in 0 shares, which EVK fails on. call convertToShares() first? Seems like overkill
815
? pause guardian
916
? how should aggregators find instances
1017
? factory/registry contract

0 commit comments

Comments
 (0)