Implement some PR review suggestions

Author: reinhardt

src/euphorie/client/navigation.py

@@ -41,7 +41,7 @@ def FindNextQuestion(after, dbsession, filter=None):
                 model.Choice.id == model.SurveyTreeItem.id,
                 sql.or_(
                     model.Choice.condition == None,  # noqa: E711
-                    model.Choice.condition.like(model.Option.zodb_path),
+                    model.Choice.condition == model.Option.zodb_path,  # noqa: E711
                 ),
             ),
         ),

src/euphorie/content/browser/choice.py

@@ -1,16 +1,9 @@
 from ..option import IOption
 from ..utils import DragDropHelper
-from Acquisition import aq_inner
 from plone.dexterity.browser.view import DefaultView
-from plone.memoize.instance import memoize
 
 
 class ChoiceView(DefaultView, DragDropHelper):
-    @property
-    @memoize
-    def my_context(self):
-        return aq_inner(self.context)
-
     @property
     def options(self):
         return [
@@ -19,6 +12,6 @@ def options(self):
                 "url": option.absolute_url(),
                 "title": option.title,
             }
-            for option in self.my_context.values()
+            for option in self.context.values()
             if IOption.providedBy(option)
         ]

src/euphorie/upgrade/content/v1/20250402124248_add_content_type__choice/types.xml

@@ -3,7 +3,7 @@
   <object meta_type="Conditional Dexterity FTI"
           name="euphorie.choice"
   />
-  <object meta_type="Conditional Dexterity FTI"
+  <object meta_type="Dexterity FTI"
           name="euphorie.option"
   />
   <object meta_type="Conditional Dexterity FTI"

src/euphorie/upgrade/content/v1/20250402124248_add_content_type__choice/types/euphorie.choice.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <object xmlns:i18n="http://xml.zope.org/namespaces/i18n"
-        meta_type="Dexterity FTI"
+        meta_type="Conditional Dexterity FTI"
         name="euphorie.choice"
         i18n:domain="euphorie"
 >