Merge pull request #24 from eure/topic/check-valid-timestamp

fix: check timestamp in sync

Author: emahiro

core/migration.go

@@ -3,6 +3,8 @@ package core
 import (
 	"io/ioutil"
 	"os"
+	"strconv"
+	"time"
 
 	"github.com/eure/kamimai/internal/cast"
 )
@@ -65,6 +67,11 @@ func (m *Migration) IsValid() bool {
 	return m.version > 0 && m.name != ""
 }
 
+func (m *Migration) IsValidTimestamp() bool {
+	_, err := time.Parse("20060102150405", strconv.FormatUint(m.version, 10))
+	return err == nil
+}
+
 //////////////////////////////
 // Migrations
 //////////////////////////////

core/service.go

@@ -256,10 +256,18 @@ func (s *Service) Sync() error {
 	if err := s.apply(); err != nil {
 		return err
 	}
+	if len(s.data) == 0 {
+		return nil
+	}
 
 	version := s.driver.Version()
-
+	// 一番目のマイグレーションファイルが Timestamp 形式だったらそれ以降は Timestamp 扱いにする
+	isTimeStampVer := s.data[0].IsValidTimestamp()
 	for _, mig := range s.data {
+		if isTimeStampVer != mig.IsValidTimestamp() {
+			return errors.New("invalid version format")
+		}
+
 		if count := version.Count(mig.version); count == 0 {
 			// gets current index of migrations
 			idx := s.data.index(*mig)