test run on CI

Author: Marcondiro

.github/workflows/build.yaml

@@ -17,7 +17,7 @@ jobs:
     - name: Install dependencies from apt
       run: |
         sudo apt update
-        sudo apt install -y make clang llvm libbpf-dev libcap-dev linux-tools-generic
+        sudo apt install -y make llvm libbpf-dev libcap-dev linux-tools-generic
     
     - name: Compile with Make
       run: |
@@ -35,4 +35,18 @@ jobs:
       with:
           name: lemon.aarch64
           path: "lemon.aarch64"
-      continue-on-error: true
+      continue-on-error: true
+  run:
+    needs: build
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-24.04-arm, ubuntu-24.04]
+    steps:
+      - name: Download artifacts
+        uses: actions/download-artifact@v4
+      - name: Run dump to disk
+        run: |
+          sudo chmod +x ./lemon.$(uname -m)/lemon.$(uname -m)
+          sudo ./lemon.$(uname -m)/lemon.$(uname -m) -d /dev/null
+# TODO build and run on NO CORE

disk.c

@@ -42,7 +42,6 @@ static int write_on_disk(void *restrict args, const void *restrict data, const u
  * generic dump function. Ensures data is flushed and file descriptor is closed.
  */
 int dump_on_disk(const struct options *restrict opts, const struct ram_regions *restrict ram_regions) {
-    
     int fd;
     int ret = 0;
 
@@ -61,9 +60,22 @@ int dump_on_disk(const struct options *restrict opts, const struct ram_regions *
     /* Dump! */
     ret = dump(opts, ram_regions, write_on_disk, (void *)&fd);
 
-    if(fd) {
-        if(fsync(fd)) { perror("Fail to finalize writes on dump file"); ret = errno; }
-        if(close(fd)) { perror("Fail to close dump file"); ret = errno; }
+    if(fsync(fd)) {
+        switch (errno) {
+            case EINVAL:
+                /* fd is bound to a special file (e.g., a pipe, FIFO, or
+                 * socket) which does not support synchronization.
+                 */
+                break;
+            default:
+                perror("Failed to finalize writes on dump file");
+                ret = errno;
+        }
+    }
+
+    if(close(fd)) {
+        perror("Failed to close the dump file");
+        ret = errno;
     }
 
     return ret;

lemon.c

@@ -124,7 +124,7 @@ int main(int argc, char **argv)
     struct ram_regions ram_regions;
     struct options opts = {0};
     struct argp argp = {options, parse_opt, "", doc};
-    int ret;
+    int ret = EXIT_SUCCESS;
 
     /* Check if is running as root */
     if(getuid() != 0) {
@@ -197,5 +197,5 @@ int main(int argc, char **argv)
         /* Restore kptr_restrict if needed */
         if((ret = toggle_kptr())) return ret;
 
-    return EXIT_SUCCESS;
+    return ret; // TODO rework all the ret values handling
 }