-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
invalidThis doesn't seem rightThis doesn't seem rightpriority-lowLow priority for next releaseLow priority for next releaserefactoringimprove the design, structure, and/or implementationimprove the design, structure, and/or implementation
Description
I see that pyowc is using 2 libraries to read Matlab mat files:
- pymatreader read_mat
- scipy.io loadmat
The former is used only once, the latter basically everywhere else.
I see from #52 that pymatreader was added to fix #30 , so in fact we can't get rid of this dependency
So why using 2 dependencies for the same task ?
Should pyowc use only 1 reader ? pymatreader only
ps: This is not considering the fact that all external data should be accessible in other formats than Matlab (eg: #53)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
invalidThis doesn't seem rightThis doesn't seem rightpriority-lowLow priority for next releaseLow priority for next releaserefactoringimprove the design, structure, and/or implementationimprove the design, structure, and/or implementation