Fix pep8 issues

Author: haeter525

quark/cli.py

@@ -148,7 +148,7 @@
     default=False,
     is_flag=True,
     help="Don't install Rizin automatically when no Rizin instance with"
-    + " a compatible version is found."
+    + " a compatible version is found.",
 )
 def entry_point(
     summary,
@@ -185,15 +185,22 @@ def entry_point(
 
             if not rizin_path:
                 print_error(
-                    "No valid Rizin executable found. Please specify the path to the Rizin executable by using option --rizin-path."
+                    "No valid Rizin executable found. Please specify the path"
+                    + "to the Rizin executable by using option --rizin-path."
                 )
                 return
             else:
                 version = get_rizin_version(rizin_path)
                 if rizin_path.startswith(config.HOME_DIR):
-                    print_info(f"Use the Rizin executable (version {version}) installed in the Quark directory.")
+                    print_info(
+                        f"Use the Rizin executable (version {version})"
+                        + " installed in the Quark directory."
+                    )
                 else:
-                    print_info(f"Use the Rizin executable (version {version}) installed in the system PATH.")
+                    print_info(
+                        f"Use the Rizin executable (version {version})"
+                        + " installed in the system PATH."
+                    )
 
         else:
             print_info(f"Use the user-specified Rizin executable.")

quark/core/quark.py

@@ -43,8 +43,10 @@ def __init__(self, apk, core_library="androguard", rizin_path=None):
         Create a Quark object.
 
         :param apk: an APK for Quark to analyze
-        :param core_library: a string indicating which analysis library Quark should use. Defaults to "androguard"
-        :param rizin_path: a PathLike object to specify a Rizin executable for the Rizin-based analysis library. Defaults to None
+        :param core_library: a string indicating which analysis library Quark
+        should use. Defaults to "androguard"
+        :param rizin_path: a PathLike object to specify a Rizin executable for
+        the Rizin-based analysis library. Defaults to None
         :raises ValueError: if an unknown core library is specified
         """
         core_library = core_library.lower()

quark/core/rzapkinfo.py

@@ -59,7 +59,8 @@ def __init__(
         if rizin_path:
             if not get_rizin_version(rizin_path):
                 raise ValueError(
-                    f"The file in {rizin_path} is not a valid Rizin executable."
+                    f"The file in {rizin_path} is not a valid Rizin"
+                    + " executable."
                 )
 
             rizin_path = os.path.dirname(rizin_path)

quark/utils/tools.py

@@ -306,7 +306,8 @@ def find_rizin_instance(
 
     # The current version is not compatible
     print_info(
-        "Find an outdated Rizin executable in the Quark directory. Try to update it."
+        "Find an outdated Rizin executable in the Quark directory. Try to"
+        + " update it."
     )
 
     if disable_rizin_installation:

tests/utils/test_tools.py

@@ -6,10 +6,15 @@
 
 import pytest
 from quark import config
-from quark.utils.tools import (contains, descriptor_to_androguard_format,
-                               download_rizin, find_rizin_instance,
-                               get_rizin_version, remove_dup_list,
-                               update_rizin)
+from quark.utils.tools import (
+    contains,
+    descriptor_to_androguard_format,
+    download_rizin,
+    find_rizin_instance,
+    get_rizin_version,
+    remove_dup_list,
+    update_rizin,
+)
 
 
 @pytest.fixture(scope="module")
@@ -189,7 +194,8 @@ def test_fail_to_download_rizin_due_to_unavailable_network(tmp_path):
         mock.side_effect = subprocess.CalledProcessError(
             "1",
             "mock command",
-            stderr=b"fatal: unable to access 'https://github.com/rizinorg/rizin/'.",
+            stderr=b"fatal: unable to access "
+            + "'https://github.com/rizinorg/rizin/'.",
         )
 
         assert not download_rizin(target_path)
@@ -258,7 +264,8 @@ def test_find_rizin_instance_installed_in_quark_directory():
         with patch(
             "quark.utils.tools.get_rizin_version"
         ) as mocked_get_version:
-            # Pretent the Rizin instance installed in the Quark directory is compatible.
+            # Pretent the Rizin instance installed in the Quark directory is
+            # compatible.
             mocked_get_version.return_value = config.COMPATIBLE_RAZIN_VERSIONS[
                 0
             ]
@@ -269,8 +276,10 @@ def test_find_rizin_instance_installed_in_quark_directory():
                 == rizin_executable_path
             )
 
-            mocked_which.assert_called()  # Must check the system path first.
-            mocked_get_version.assert_called()  # Must check the version of the instance in the Quark directory.
+            # Must check the system path first.
+            mocked_which.assert_called()
+            # Must check the version of the instance in the Quark directory.
+            mocked_get_version.assert_called()
 
 
 def test_find_outdated_rizin_instance_installed_in_quark_directory(
@@ -287,7 +296,8 @@ def test_find_outdated_rizin_instance_installed_in_quark_directory(
         with patch(
             "quark.utils.tools.get_rizin_version"
         ) as mocked_get_version:
-            # Pretent the Rizin instance installed in the Quark directory is not compatible.
+            # Pretent the Rizin instance installed in the Quark directory is
+            # not compatible.
             mocked_get_version.return_value = "0.0.0"
 
             with patch(
@@ -306,12 +316,17 @@ def test_find_outdated_rizin_instance_installed_in_quark_directory(
                     == rizin_executable_path
                 )
 
-                mocked_which.assert_called()  # Must check the system path first.
-                mocked_get_version.assert_called()  # Must check the version of the instance in the Quark directory.
+                # Must check the system path first.
+                mocked_which.assert_called()
+                # Must check the version of the instance in the Quark
+                # directory.
+                mocked_get_version.assert_called()
                 if disable_rizin_installation:
-                    mocked_update_rizin.assert_not_called()  # Must not update the instance
+                    # Must not update the instance
+                    mocked_update_rizin.assert_not_called()
                 else:
-                    mocked_update_rizin.assert_called()  # Must update the instance to a compatible version
+                    # Must update the instance to a compatible version
+                    mocked_update_rizin.assert_called()
 
 
 _compatible_trigger = None
@@ -367,20 +382,27 @@ def test_find_broken_rizin_instance_installed_in_quark_directory(
                     )
                     if disable_rizin_installation:
                         # No Rizin instance exists
-                        assert result == None
+                        assert result is None
                     else:
                         # Must use the instance in the Quark directory.
                         assert result == rizin_executable_path
 
-                    mocked_which.assert_called()  # Must check the system path first.
-                    mocked_get_version.assert_called()  # Must check the version of the instance in the Quark directory.
+                    # Must check the system path first.
+                    mocked_which.assert_called()
+                    # Must check the version of the instance in the Quark
+                    # directory.
+                    mocked_get_version.assert_called()
 
                     if disable_rizin_installation:
-                        mocked_download_rizin.assert_not_called()  # Must not download the source code.
-                        mocked_update_rizin.assert_not_called()  # Must not update and compile a Rizin instance.
+                        # Must not download the source code.
+                        mocked_download_rizin.assert_not_called()
+                        # Must not update and compile a Rizin instance.
+                        mocked_update_rizin.assert_not_called()
                     else:
-                        mocked_download_rizin.assert_called()  # Must download the source code.
-                        mocked_update_rizin.assert_called()  # Must update and compile a Rizin instance.
+                        # Must download the source code.
+                        mocked_download_rizin.assert_called()
+                        # Must update and compile a Rizin instance.
+                        mocked_update_rizin.assert_called()
 
 
 def test_find_rizin_instance_failed_to_download_the_source():
@@ -394,7 +416,8 @@ def test_find_rizin_instance_failed_to_download_the_source():
         with patch(
             "quark.utils.tools.get_rizin_version"
         ) as mocked_get_version:
-            # Pretent the Rizin instance installed in the Quark directory is broken.
+            # Pretent the Rizin instance installed in the Quark directory is
+            # broken.
             mocked_get_version.return_value = None
 
             with patch(
@@ -406,12 +429,16 @@ def test_find_rizin_instance_failed_to_download_the_source():
                 # Must use the instance in the Quark directory.
                 assert (
                     find_rizin_instance(rizin_source_path, target_commit)
-                    == None
+                    is None
                 )
 
-                mocked_which.assert_called()  # Must check the system path first.
-                mocked_get_version.assert_called()  # Must check the version of the instance in the Quark directory.
-                mocked_download_rizin.assert_called()  # Must try to download the source code of the Rizin.
+                # Must check the system path first.
+                mocked_which.assert_called()
+                # Must check the version of the instance in the Quark
+                # directory.
+                mocked_get_version.assert_called()
+                # Must try to download the source code of the Rizin.
+                mocked_download_rizin.assert_called()
 
 
 def test_find_rizin_instance_failed_to_compile_or_update_the_source():
@@ -425,7 +452,8 @@ def test_find_rizin_instance_failed_to_compile_or_update_the_source():
         with patch(
             "quark.utils.tools.get_rizin_version"
         ) as mocked_get_version:
-            # Pretent the Rizin instance installed in the Quark directory is not compatible.
+            # Pretent the Rizin instance installed in the Quark directory is
+            # not compatible.
             mocked_get_version.return_value = "0.0.0"
 
             with patch(
@@ -437,9 +465,13 @@ def test_find_rizin_instance_failed_to_compile_or_update_the_source():
                 # Must use the instance in the Quark directory.
                 assert (
                     find_rizin_instance(rizin_source_path, target_commit)
-                    == None
+                    is None
                 )
 
-                mocked_which.assert_called()  # Must check the system path first.
-                mocked_get_version.assert_called()  # Must check the version of the instance in the Quark directory.
-                mocked_update_rizin.assert_called()  # Must try to update and compile a Rizin instance.
+                # Must check the system path first.
+                mocked_which.assert_called()
+                # Must check the version of the instance in the Quark
+                # directory.
+                mocked_get_version.assert_called()
+                # Must try to update and compile a Rizin instance.
+                mocked_update_rizin.assert_called()