Skip to content

Commit 5e8bf9f

Browse files
Michal Simekgregkh
authored andcommitted
earlycon: Remove hardcoded port->uartclk initialization in of_setup_earlycon
commit 182ead3 upstream. There is no reason to initialize uartclk to BASE_BAUD * 16 for DT based systems. [-stable comment: commit 31cb9a8 ("earlycon: initialise baud field of earlycon device structure") has changed 8250_early.c behavior which now tries to setup UART speed. Already-backported upstream commit 0ff3ab7 ("serial: 8250_early: Only set divisor if valid clk & baud") handles properly uartclk not being set but it still requires backporting fix for wrong uartclk val. This fixes malformed early console output on arch-es with BASE_BAUD.] Fixes: 31cb9a8 ("earlycon: initialise baud field of earlycon device structure") Signed-off-by: Michal Simek <[email protected]> Tested-by: Matt Redfearn <[email protected]> [rmilecki: add -stable comment and Fixes tag] Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent a44d267 commit 5e8bf9f

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/tty/serial/earlycon.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@ int __init of_setup_earlycon(const struct earlycon_id *match,
254254
return -ENXIO;
255255
}
256256
port->mapbase = addr;
257-
port->uartclk = BASE_BAUD * 16;
258257

259258
val = of_get_flat_dt_prop(node, "reg-offset", NULL);
260259
if (val)

0 commit comments

Comments
 (0)