Skip to content

Commit c86bd68

Browse files
committed
Fix stop button not killing all child processes
console-runner creates a process group, so we have to use the --group option on conrun-kill to ensure that all child processes are ended. Fixes #103
1 parent 3c5fcac commit c86bd68

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
77
### Changed
88
- Initial debug configuration has new example to run current file
99
### Fixed
10+
- Stop button does not kill all child processes
1011
- Activate extension on command palette command
1112
### Added
1213
- ev3dev remote debugger is now a default debugger for Python files

src/extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ async function handleCustomDebugEvent(event: vscode.DebugSessionCustomEvent): Pr
308308
debugRestarting = event.body.restart;
309309
device = ev3devBrowserProvider.getDeviceSync();
310310
if (activeDebugSessions.has(event.session.id) && device && device.isConnected) {
311-
device.exec('conrun-kill --signal=SIGKILL');
311+
device.exec('conrun-kill --signal=SIGKILL --group');
312312
}
313313
// update remote file browser in case program created new files
314314
refresh();

0 commit comments

Comments
 (0)