Fix test string constants

Author: haasonsaas

services/authz/server/server.go

@@ -42,6 +42,8 @@ const (
 	defaultRetryMultiplier   = 1.5
 	defaultMaxInterval       = 2 * time.Second
 	emptyString              = ""
+	contentTypeHeader        = "Content-Type"
+	applicationJSON          = "application/json"
 	errDecodeRequest         = "bad request"
 	errMissingMFAParams      = "missing MFA parameters"
 	errMethodNotAllowed      = "method not allowed"
@@ -155,7 +157,7 @@ func New(cfg Config) (*Server, error) {
 		})
 	})
 
-	useTLS := cfg.TLSCertPath != "" && cfg.TLSKeyPath != ""
+	useTLS := cfg.TLSCertPath != emptyString && cfg.TLSKeyPath != emptyString
 	if useTLS {
 		cert, err := tls.LoadX509KeyPair(cfg.TLSCertPath, cfg.TLSKeyPath)
 		if err != nil {
@@ -281,7 +283,7 @@ func (s *Server) healthHandler(w http.ResponseWriter, _ *http.Request) {
 		"tailscale": s.getTailscaleInfo(),
 	}
 
-	w.Header().Set("Content-Type", "application/json")
+	w.Header().Set(contentTypeHeader, applicationJSON)
 	w.WriteHeader(http.StatusOK)
 	if err := json.NewEncoder(w).Encode(health); err != nil {
 		log.Printf("failed to encode health response: %v", err)
@@ -394,7 +396,7 @@ func (s *Server) envoyAuthHandler(w http.ResponseWriter, r *http.Request) {
 		}
 		w.WriteHeader(http.StatusOK)
 	case decisionStepUp:
-		w.Header().Set("Content-Type", "application/json")
+		w.Header().Set(contentTypeHeader, applicationJSON)
 		w.WriteHeader(http.StatusForbidden)
 		response := map[string]interface{}{
 			"error":      "mfa_required",
@@ -432,7 +434,7 @@ func (s *Server) evaluateOPA(ctx context.Context, claims map[string]any, deviceI
 	if err != nil {
 		return "", err
 	}
-	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set(contentTypeHeader, applicationJSON)
 
 	start := time.Now()
 	var resp *http.Response
@@ -814,7 +816,7 @@ func (s *Server) tailscaleStatusHandler(w http.ResponseWriter, r *http.Request)
 	}
 
 	status := s.getTailscaleInfo()
-	w.Header().Set("Content-Type", "application/json")
+	w.Header().Set(contentTypeHeader, applicationJSON)
 	w.WriteHeader(http.StatusOK)
 	if err := json.NewEncoder(w).Encode(status); err != nil {
 		log.Printf("failed to encode tailscale status: %v", err)
@@ -927,7 +929,7 @@ func (s *Server) verifyMFACode(ctx context.Context, sessionID, code string) (boo
 	if err != nil {
 		return false, err
 	}
-	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set(contentTypeHeader, applicationJSON)
 
 	start := time.Now()
 	var resp *http.Response

services/authz/server/server_test.go

@@ -14,11 +14,13 @@ import (
 )
 
 const (
-	testDeviceID       = "test-device"
-	testAllowPath      = "/v1/data/keep/allow"
-	testClientRemoteIP = "100.65.1.1:12345"
-	resultKey          = "result"
-	decisionKey        = "decision"
+	testDeviceID           = "test-device"
+	testAllowPath          = "/v1/data/keep/allow"
+	testClientRemoteIP     = "100.65.1.1:12345"
+	resultKey              = "result"
+	decisionKey            = "decision"
+	testRejectsNonPOST     = testRejectsNonPOST
+	testRejectsInvalidJSON = testRejectsInvalidJSON
 )
 
 // TestServer_healthHandler tests the health endpoint
@@ -52,7 +54,7 @@ func TestServer_healthHandler(t *testing.T) {
 func TestServer_verifyHandler(t *testing.T) {
 	server := createTestServer(t)
 
-	t.Run("rejects non-POST methods", func(t *testing.T) {
+	t.Run(testRejectsNonPOST, func(t *testing.T) {
 		req := httptest.NewRequest(http.MethodGet, "/v1/auth/verify", nil)
 		rr := httptest.NewRecorder()
 
@@ -63,7 +65,7 @@ func TestServer_verifyHandler(t *testing.T) {
 		}
 	})
 
-	t.Run("rejects invalid JSON", func(t *testing.T) {
+	t.Run(testRejectsInvalidJSON, func(t *testing.T) {
 		req := httptest.NewRequest(http.MethodPost, "/v1/auth/verify", bytes.NewReader([]byte("invalid json")))
 		rr := httptest.NewRecorder()
 
@@ -187,7 +189,7 @@ func TestServer_envoyAuthHandler(t *testing.T) {
 
 	server := createTestServerWithMocks(t, mockOPA.URL, mockInventory.URL)
 
-	t.Run("rejects non-POST methods", func(t *testing.T) {
+	t.Run(testRejectsNonPOST, func(t *testing.T) {
 		req := httptest.NewRequest(http.MethodGet, "/v1/auth/check", nil)
 		rr := httptest.NewRecorder()
 
@@ -198,7 +200,7 @@ func TestServer_envoyAuthHandler(t *testing.T) {
 		}
 	})
 
-	t.Run("rejects invalid JSON", func(t *testing.T) {
+	t.Run(testRejectsInvalidJSON, func(t *testing.T) {
 		req := httptest.NewRequest(http.MethodPost, "/v1/auth/check", bytes.NewReader([]byte("invalid json")))
 		rr := httptest.NewRecorder()
 
@@ -513,7 +515,7 @@ func TestServer_lookupDevice(t *testing.T) {
 func TestServer_deviceCertHandler(t *testing.T) {
 	server := createTestServer(t)
 
-	t.Run("rejects non-POST methods", func(t *testing.T) {
+	t.Run(testRejectsNonPOST, func(t *testing.T) {
 		req := httptest.NewRequest(http.MethodGet, "/v1/certs/device", nil)
 		rr := httptest.NewRecorder()
 
@@ -524,7 +526,7 @@ func TestServer_deviceCertHandler(t *testing.T) {
 		}
 	})
 
-	t.Run("rejects invalid JSON", func(t *testing.T) {
+	t.Run(testRejectsInvalidJSON, func(t *testing.T) {
 		req := httptest.NewRequest(http.MethodPost, "/v1/certs/device", bytes.NewReader([]byte("invalid json")))
 		rr := httptest.NewRecorder()