Use constants consistently in test files

- Replace hardcoded 'test-device' string literals with existing testDeviceCN and testDeviceID constants
- Improve test maintainability by using centralized test constants
- Ensure consistent test data across PKI and service test suites
- Address goconst linting issues in test files

Files updated:
- agent/internal/service/service_test.go: Use testDeviceID constant
- pkg/pki/device_test.go: Add and use testDeviceCN constant
- pkg/pki/ca_test.go: Use existing testDeviceCN constant

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-5be4213f-26eb-400c-bb7b-d4c79b7ee6fe

Author: haasonsaas

agent/internal/service/service_test.go

@@ -313,7 +313,7 @@ func TestService_obtainCertificate(t *testing.T) {
 					return
 				}
 
-				if req["device_id"] != "test-device" {
+				if req["device_id"] != testDeviceID {
 					t.Errorf("Expected device ID 'test-device', got %s", req["device_id"])
 				}
 
@@ -341,7 +341,7 @@ func TestService_obtainCertificate(t *testing.T) {
 		defer mockAuthz.Close()
 
 		config := &Config{
-			DeviceID:  "test-device",
+			DeviceID:  testDeviceID,
 			AttestURL: mockAuthz.URL,
 			CertPath:  filepath.Join(tmpDir, "device.crt"),
 			CAPath:    filepath.Join(tmpDir, "ca.pem"),
@@ -384,7 +384,7 @@ func TestService_obtainCertificate(t *testing.T) {
 		defer mockAuthz.Close()
 
 		config := &Config{
-			DeviceID:  "test-device",
+			DeviceID:  testDeviceID,
 			AttestURL: mockAuthz.URL,
 			CertPath:  filepath.Join(tmpDir, "device.crt"),
 			CAPath:    filepath.Join(tmpDir, "ca.pem"),

lint_priority1.json

@@ -224,7 +224,7 @@ func TestCertificateAuthority_IssueCertificate(t *testing.T) {
 	})
 
 	t.Run("uses default TTL when zero", func(t *testing.T) {
-		subject := pkix.Name{CommonName: "test-device"}
+		subject := pkix.Name{CommonName: testDeviceCN}
 
 		certPEM, err := ca.IssueCertificate(subject, nil, nil, 0, &priv.PublicKey)
 		if err != nil {
@@ -245,7 +245,7 @@ func TestCertificateAuthority_IssueCertificate(t *testing.T) {
 	})
 
 	t.Run("handles invalid URI", func(t *testing.T) {
-		subject := pkix.Name{CommonName: "test-device"}
+		subject := pkix.Name{CommonName: testDeviceCN}
 		invalidURIs := []string{"not://a valid uri with spaces"}
 
 		_, err := ca.IssueCertificate(subject, invalidURIs, nil, time.Hour, &priv.PublicKey)

pkg/pki/ca_test.go

@@ -17,6 +17,7 @@ const (
 	testKeyName        = "test.key"
 	benchKeyName       = "bench.key"
 	msgGenerateKeyFail = "Failed to generate key: %v"
+	testDeviceCN       = "test-device"
 )
 
 func TestGenerateSigningKey(t *testing.T) {
@@ -441,7 +442,7 @@ func TestCertificateExpiry(t *testing.T) {
 
 		// Issue a certificate with known TTL
 		ttl := 2 * time.Hour
-		subject := pkix.Name{CommonName: "test-device"}
+		subject := pkix.Name{CommonName: testDeviceCN}
 		certPEM, err := ca.IssueCertificate(subject, nil, nil, ttl, &priv.PublicKey)
 		if err != nil {
 			t.Fatalf("Failed to issue certificate: %v", err)