fix: handle migrate close errors

haasonsaas · haasonsaas · commit 97578056b134 · 2025-10-18T21:45:38.000-07:00
diff --git a/cmd/migrate/main.go b/cmd/migrate/main.go
@@ -47,8 +47,12 @@ func run() error {
 		return fmt.Errorf("init migrator: %w", err)
 	}
 	defer func() {
-		if closeErr := m.Close(); closeErr != nil && !errors.Is(closeErr, migrate.ErrNoChange) {
-			log.Printf("migrate close: %v", closeErr)
+		sourceErr, dbErr := m.Close()
+		if sourceErr != nil && !errors.Is(sourceErr, migrate.ErrNoChange) {
+			log.Printf("migrate source close: %v", sourceErr)
+		}
+		if dbErr != nil && !errors.Is(dbErr, migrate.ErrNoChange) {
+			log.Printf("migrate db close: %v", dbErr)
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,12 @@ func run() error {`
`47`	`47`	`return fmt.Errorf("init migrator: %w", err)`
`48`	`48`	`}`
`49`	`49`	`defer func() {`
`50`		`- if closeErr := m.Close(); closeErr != nil && !errors.Is(closeErr, migrate.ErrNoChange) {`
`51`		`- log.Printf("migrate close: %v", closeErr)`
	`50`	`+ sourceErr, dbErr := m.Close()`
	`51`	`+ if sourceErr != nil && !errors.Is(sourceErr, migrate.ErrNoChange) {`
	`52`	`+ log.Printf("migrate source close: %v", sourceErr)`
	`53`	`+ }`
	`54`	`+ if dbErr != nil && !errors.Is(dbErr, migrate.ErrNoChange) {`
	`55`	`+ log.Printf("migrate db close: %v", dbErr)`
`52`	`56`	`}`
`53`	`57`	`}()`
`54`	`58`