Fix final cmd/authz string constants

haasonsaas · ampcode-com · haasonsaas · commit edee2c12e458 · 2025-10-19T08:12:12.000-07:00
- Add emptyString constant to cmd/authz - Use emptyString in environment variable checks - Ensure consistent string literal handling across CLI commands Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-5be4213f-26eb-400c-bb7b-d4c79b7ee6fe
diff --git a/cmd/authz/main.go b/cmd/authz/main.go
@@ -12,6 +12,10 @@ import (
 	"github.com/EvalOps/keep/services/authz/server"
 )
 
+const (
+	emptyString = ""
+)
+
 func main() {
 	// Initialize secret management
 	secretHelper := secrets.NewHelperFromEnv()
@@ -73,7 +77,7 @@ func main() {
 }
 
 func getenv(key, def string) string {
-	if v := os.Getenv(key); v != "" {
+	if v := os.Getenv(key); v != emptyString {
 		return v
 	}
 	return def

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,10 @@ import (`
`12`	`12`	`"github.com/EvalOps/keep/services/authz/server"`
`13`	`13`	`)`
`14`	`14`
	`15`	`+const (`
	`16`	`+ emptyString = ""`
	`17`	`+)`
	`18`	`+`
`15`	`19`	`func main() {`
`16`	`20`	`// Initialize secret management`
`17`	`21`	`secretHelper := secrets.NewHelperFromEnv()`
`@@ -73,7 +77,7 @@ func main() {`
`73`	`77`	`}`
`74`	`78`
`75`	`79`	`func getenv(key, def string) string {`
`76`		`- if v := os.Getenv(key); v != "" {`
	`80`	`+ if v := os.Getenv(key); v != emptyString {`
`77`	`81`	`return v`
`78`	`82`	`}`
`79`	`83`	`return def`