Update posture collection and improve server tests

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-5be4213f-26eb-400c-bb7b-d4c79b7ee6fe

Author: haasonsaas

agent/internal/posture/constants.go

@@ -3,10 +3,12 @@ package posture
 const (
 	UnknownValue         = "Unknown"
 	UnknownService       = "unknown"
+	emptyString          = ""
 	newline              = "\n"
 	colonSeparator       = ":"
 	spaceSeparator       = " "
 	minPartsTriple       = 3
+	keyValueParts        = 2
 	macOSVersionKey      = "System Version:"
 	macOSKernelKey       = "Kernel Version:"
 	macOSFirewallService = "pf"

agent/internal/posture/posture.go

@@ -70,7 +70,7 @@ func (p *DevicePosture) ToJSON() (string, error) {
 
 // CalculateTrustScore calculates an overall trust score based on posture
 func (p *DevicePosture) CalculateTrustScore() {
-	score := 0
+	score := DefaultRules
 
 	if p.OS.Supported {
 		score += TrustBonusOS
@@ -140,12 +140,12 @@ func parseKeyValue(text string) map[string]string {
 
 	for scanner.Scan() {
 		line := strings.TrimSpace(scanner.Text())
-		if line == "" || strings.HasPrefix(line, "#") {
+		if line == emptyString || strings.HasPrefix(line, "#") {
 			continue
 		}
 
 		parts := strings.SplitN(line, "=", 2)
-		if len(parts) == 2 {
+		if len(parts) == keyValueParts {
 			key := strings.TrimSpace(parts[0])
 			value := strings.Trim(strings.TrimSpace(parts[1]), "\"")
 			result[key] = value
@@ -160,5 +160,5 @@ func parseInt(s string) int {
 	if val, err := strconv.Atoi(s); err == nil {
 		return val
 	}
-	return 0
+	return DefaultRules
 }

services/authz/server/server_test.go

@@ -483,8 +483,8 @@ func TestServer_lookupDevice(t *testing.T) {
 
 		result := server.lookupDevice(context.Background(), "")
 
-		if result["posture"] != "unknown" {
-			t.Errorf("Expected posture 'unknown' for empty device ID, got %v", result["posture"])
+		if result["posture"] != statusUnknown {
+			t.Errorf("Expected posture %q for empty device ID, got %v", statusUnknown, result["posture"])
 		}
 	})
 
@@ -501,8 +501,8 @@ func TestServer_lookupDevice(t *testing.T) {
 
 		result := server.lookupDevice(ctx, testDeviceID)
 
-		if result["posture"] != "unknown" {
-			t.Errorf("Expected posture 'unknown' for service error, got %v", result["posture"])
+		if result["posture"] != statusUnknown {
+			t.Errorf("Expected posture %q for service error, got %v", statusUnknown, result["posture"])
 		}
 	})
 }