Fix Docker builds and critical linting issues

Docker build fixes:
- Add GOTOOLCHAIN=auto to all Go Dockerfiles
- Ensure Go version auto-upgrade in container builds
- Fix 'go.mod requires go >= 1.24.0' errors

Additional linting fixes:
- Add directory permission constants (dirPermissions, dirPermissionsSecure)
- Use existing constants for version checks (MinWindowsVersion, MinMacOSVersion)
- Fix string splitting to use keyValueParts constant
- Replace magic number directory permissions with named constants

Reduces remaining lint issues to ~33 (down from 50+)

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-5be4213f-26eb-400c-bb7b-d4c79b7ee6fe

Author: haasonsaas

pkg/pki/device.go

@@ -15,8 +15,10 @@ import (
 )
 
 const (
-	defaultKeyPerm  = 0o600
-	defaultCertPerm = 0o600
+	defaultKeyPerm       = 0o600
+	defaultCertPerm      = 0o600
+	dirPermissions       = 0o700
+	dirPermissionsSecure = 0o750
 )
 
 // GenerateSigningKey creates a new P256 ECDSA key and writes it to the provided path in PEM (PKCS8) format.
@@ -31,7 +33,7 @@ func GenerateSigningKey(path string) (*ecdsa.PrivateKey, error) {
 		return nil, err
 	}
 
-	if err := os.MkdirAll(filepath.Dir(absPath), 0o700); err != nil {
+	if err := os.MkdirAll(filepath.Dir(absPath), dirPermissions); err != nil {
 		return nil, err
 	}
 
@@ -135,7 +137,7 @@ func WriteCertificate(path string, pemData []byte) error {
 		return err
 	}
 
-	if err := os.MkdirAll(filepath.Dir(absPath), 0o750); err != nil {
+	if err := os.MkdirAll(filepath.Dir(absPath), dirPermissionsSecure); err != nil {
 		return err
 	}
 

services/authz/Dockerfile

@@ -2,10 +2,10 @@ FROM golang:1.24 AS build
 
 WORKDIR /src
 COPY go.mod go.sum ./
-RUN go mod download
+RUN GOTOOLCHAIN=auto go mod download
 
 COPY . .
-RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o /out/authz ./cmd/authz
+RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GOTOOLCHAIN=auto go build -o /out/authz ./cmd/authz
 
 FROM gcr.io/distroless/base-debian12
 WORKDIR /

services/inventory/Dockerfile

@@ -2,10 +2,10 @@ FROM golang:1.24 AS build
 
 WORKDIR /src
 COPY go.mod go.sum ./
-RUN go mod download
+RUN GOTOOLCHAIN=auto go mod download
 
 COPY . .
-RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o /out/inventory ./services/inventory/server
+RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GOTOOLCHAIN=auto go build -o /out/inventory ./services/inventory/server
 
 FROM gcr.io/distroless/base-debian12
 COPY --from=build /out/inventory /inventory

services/mfa/Dockerfile

@@ -3,10 +3,10 @@ FROM golang:1.24-alpine AS builder
 # Updated to fix Go version compatibility - requires Go 1.24+
 WORKDIR /app
 COPY go.mod go.sum ./
-RUN go mod download
+RUN GOTOOLCHAIN=auto go mod download
 
 COPY . .
-RUN go build -o mfa ./cmd/mfa
+RUN GOTOOLCHAIN=auto go build -o mfa ./cmd/mfa
 
 FROM scratch