Skip to content

Commit f72215a

Browse files
committed
Simplify timestamp parsing
1 parent 5801072 commit f72215a

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

vehicle/kamereon/api.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,7 @@ func (v *API) FinishTime() (time.Time, error) {
8484
res, err := v.apiG()
8585

8686
if res, ok := res.(Response); err == nil && ok {
87-
var timestamp time.Time
88-
if err == nil {
89-
timestamp, err = time.Parse(time.RFC3339, res.Data.Attributes.Timestamp)
90-
}
87+
timestamp, err := time.Parse(time.RFC3339, res.Data.Attributes.Timestamp)
9188

9289
if res.Data.Attributes.RemainingTime == nil {
9390
return time.Time{}, api.ErrNotAvailable

vehicle/renault.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -359,10 +359,7 @@ func (v *Renault) FinishTime() (time.Time, error) {
359359
res, err := v.apiG()
360360

361361
if res, ok := res.(kamereonResponse); err == nil && ok {
362-
var timestamp time.Time
363-
if err == nil {
364-
timestamp, err = time.Parse(time.RFC3339, res.Data.Attributes.Timestamp)
365-
}
362+
timestamp, err := time.Parse(time.RFC3339, res.Data.Attributes.Timestamp)
366363

367364
if res.Data.Attributes.RemainingTime == nil {
368365
return time.Time{}, api.ErrNotAvailable

vehicle/volvo.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func (v *Volvo) vehicles() ([]string, error) {
169169
return vehicles, err
170170
}
171171

172-
func (v *Volvo) status() (volvoStatus, error) {
172+
func (v *Volvo) status() (interface{}, error) {
173173
var res volvoStatus
174174

175175
req, err := v.request(fmt.Sprintf("%s/vehicles/%s/status", volvoAPI, v.vin))
@@ -199,3 +199,14 @@ func (v *Volvo) VehicleRange() (int64, error) {
199199

200200
return 0, err
201201
}
202+
203+
// // FinishTime implements the ChargeFinishTimer interface
204+
// func (v *Volvo) FinishTime() (time.Time, error) {
205+
// res, err := v.statusG()
206+
// if res, ok := res.(volvoStatus); err == nil && ok {
207+
// timestamp, err := time.Parse(time.RFC3339, res.HvBattery.TimeToHVBatteryFullyChargedTimestamp)
208+
// return timestamp.Add(time.Duration(res.HvBattery.DistanceToHVBatteryEmpty) * time.Minute), err
209+
// }
210+
211+
// return time.Time{}, err
212+
// }

vehicle/vw/provider.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,7 @@ func (v *Provider) FinishTime() (time.Time, error) {
6565
return time.Time{}, api.ErrNotAvailable
6666
}
6767

68-
var timestamp time.Time
69-
timestamp, err = time.Parse(time.RFC3339, rct.Timestamp)
70-
68+
timestamp, err := time.Parse(time.RFC3339, rct.Timestamp)
7169
return timestamp.Add(time.Duration(rct.Content) * time.Minute), err
7270
}
7371

0 commit comments

Comments
 (0)