Upgrade emmett-expressjs to use express v5

[Bazze]

Hello!

I was about the get started and try emmett out, but using express v5 I immediately stumbled upon npm install.

I've created a fork & branch and applied changes (see diff: https://github.com/event-driven-io/emmett/compare/main...Bazze:emmett:fix/upgrade-to-express-v5?expand=1). Tests seems to be passing. I consulted the the migration guide and took some AI help to verify an extra time.

Just wanted to check if there is a specific reason it's been held off until now? Maybe it's not as easy as I think.

Let me know if I should open the PR!

[oskardudycz]

@Bazze, the only reason for now was that I didn't have much time to go through that, and that v4 is still a popular choice. If that works, then sure, I'll be happy to take a Pull Request :)

[Bazze]

Roger that! Thanks for the answer. It was not as simple as I thought, but also I've ended up not using the emmett-expressjs lib. I need to customize more 🙏

Do you want me to close the issue or keep it open?

[oskardudycz]

@Bazze thanks for following up, much appreciated. Maybe we could discuss considering adding more extension points to Emmett so it was possible to use it.

I’m curious what what was missing or not flexible enough for you. My goal behind Express package is not to enforce much but reduce boilerplate.

If not then I’d also appreciate some more hints on upgrade. Then it would be useful to me or another person who’d take it.

[Bazze]

Sorry for the shortness, my apologies 😊

So background is that I'm on a very much learning journey, first time into event sourcing, and evaluating if it's a pattern for a new project or not. With this, a lot of shopping around for different libraries and utils. I found the emmett libs very promising and currently PoCing with it!

What made me stop using the emmett-expressjs was mostly not having control of the express application, to be able to apply middleware in the order I needed. It might be a I come back trying the lib again once the PoC phase is over and I understand what I actually need 😅

[oskardudycz]

Ah, then feel invited to join our Discord, where we can discuss in detail your concerns and help you on this journey: https://discord.gg/fTpqUTMmVa 🙂

Regarding customising the middleware order etc, I’m open to that.