fix(ai): applied AI suggestions from stage apps branch (#9597)

* Apply suggestion from @coderabbitai[bot]

* Update apps/desktop/src/index.ts

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* Update .scripts/electron-desktop-environment/concrete-environment-content/desktop-environment-content.ts

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Author: 3 people

.scripts/electron-desktop-environment/concrete-environment-content/desktop-api-server-environment-content.ts

@@ -1,5 +1,6 @@
 import { IContentGenerator } from '../interfaces/i-content-generator';
 import { IDesktopEnvironment } from '../interfaces/i-desktop-environment';
+import { escapeForSingleQuote } from '../utils/escape-string';
 
 export class DesktopApiServerEnvironmentContent implements IContentGenerator {
 	/**
@@ -30,8 +31,8 @@ export class DesktopApiServerEnvironmentContent implements IContentGenerator {
 			IS_DESKTOP: ${false},
 			IS_SERVER: ${true},
 			IS_SERVER_API: ${true},
-			JWT_SECRET: '${variable.DESKTOP_JWT_SECRET || ''}',
-			JWT_REFRESH_TOKEN_SECRET: '${variable.DESKTOP_JWT_REFRESH_TOKEN_SECRET || ''}'
+			JWT_SECRET: '${escapeForSingleQuote(variable.DESKTOP_JWT_SECRET || '')}',
+			JWT_REFRESH_TOKEN_SECRET: '${escapeForSingleQuote(variable.DESKTOP_JWT_REFRESH_TOKEN_SECRET || '')}'
 		`;
 	}
 }

.scripts/electron-desktop-environment/concrete-environment-content/desktop-server-environment-content.ts

@@ -1,5 +1,6 @@
 import { IContentGenerator } from '../interfaces/i-content-generator';
 import { IDesktopEnvironment } from '../interfaces/i-desktop-environment';
+import { escapeForSingleQuote } from '../utils/escape-string';
 
 export class DesktopServerEnvironmentContent implements IContentGenerator {
 	/**
@@ -30,8 +31,8 @@ export class DesktopServerEnvironmentContent implements IContentGenerator {
 			IS_DESKTOP: ${false},
 			IS_SERVER: ${true},
 			IS_SERVER_API: ${false},
-			JWT_SECRET: '${variable.DESKTOP_JWT_SECRET || ''}',
-			JWT_REFRESH_TOKEN_SECRET: '${variable.DESKTOP_JWT_REFRESH_TOKEN_SECRET || ''}'
+			JWT_SECRET: '${escapeForSingleQuote(variable.DESKTOP_JWT_SECRET || '')}',
+			JWT_REFRESH_TOKEN_SECRET: '${escapeForSingleQuote(variable.DESKTOP_JWT_REFRESH_TOKEN_SECRET || '')}'
 		`;
 	}
 }

.scripts/electron-desktop-environment/utils/escape-string.ts

@@ -0,0 +1,13 @@
+/**
+ * Escapes a string so it can be safely embedded inside a single-quoted
+ * JavaScript string literal in generated source code.
+ *
+ * Handles backslashes, single quotes, and newline characters that would
+ * otherwise break or alter the emitted string.
+ *
+ * @param value - The raw string to escape.
+ * @returns The escaped string, safe for single-quote interpolation.
+ */
+export function escapeForSingleQuote(value: string): string {
+	return value.replace(/\\/g, '\\\\').replace(/'/g, "\\'").replace(/\n/g, '\\n').replace(/\r/g, '\\r');
+}

apps/desktop/src/index.ts

@@ -347,8 +347,12 @@ async function startServer(setupConfig: DesktopSetupConfig, restart = false) {
 		process.env.API_PORT = setupConfig.port ? String(setupConfig.port) : String(environment.API_DEFAULT_PORT);
 		process.env.API_HOST = '0.0.0.0';
 		process.env.API_BASE_URL = `http://127.0.0.1:${setupConfig.port || environment.API_DEFAULT_PORT}`;
-		process.env.JWT_SECRET = setupConfig.secret?.jwt;
-		process.env.JWT_REFRESH_TOKEN_SECRET = setupConfig.secret?.refresh_token;
+
+		if (!setupConfig.secret || !setupConfig.secret.jwt || !setupConfig.secret.refresh_token) {
+			throw new AppError('MAINSTRSERVER', new Error('JWT secrets are required for local server startup'));
+		}
+		process.env.JWT_SECRET = setupConfig.secret.jwt;
+		process.env.JWT_REFRESH_TOKEN_SECRET = setupConfig.secret.refresh_token;
 
 		console.log('Setting additional environment variables...', process.env.API_PORT);
 		console.log('Setting additional environment variables...', process.env.API_HOST);