bugfix: in case of a schema with additionalProperties=false and a subject with multiple additional properties, only the first additional property was reported

Author: erosb

core/src/main/java/org/everit/json/schema/ObjectSchema.java

@@ -276,11 +276,9 @@ public boolean requiresObject() {
   private List<ValidationException> testAdditionalProperties(final JSONObject subject) {
     if (!additionalProperties) {
       return getAdditionalProperties(subject)
-          .findFirst()
           .map(unneeded -> String.format("extraneous key [%s] is not permitted", unneeded))
           .map(msg -> new ValidationException(this, msg))
-          .map(exc -> Arrays.asList(exc))
-          .orElse(Collections.emptyList());
+          .collect(Collectors.toList());
     } else if (schemaOfAdditionalProperties != null) {
       List<String> additionalPropNames = getAdditionalProperties(subject)
           .collect(Collectors.toList());

core/src/test/java/org/everit/json/schema/ObjectSchemaTest.java

@@ -53,6 +53,18 @@ public void minPropertiesFailure() {
     TestSupport.expectFailure(subject, "#", OBJECTS.get("minPropertiesFailure"));
   }
 
+  @Test
+  public void multipleAdditionalProperties() {
+    ObjectSchema subject = ObjectSchema.builder().additionalProperties(false).build();
+    try {
+      subject.validate(new JSONObject("{\"a\":true,\"b\":true}"));
+      Assert.fail("did not throw exception for multiple additional properties");
+    } catch (ValidationException e) {
+      Assert.assertEquals("#: 2 schema violations found", e.getMessage());
+      Assert.assertEquals(2, e.getCausingExceptions().size());
+    }
+  }
+
   @Test
   public void multipleSchemaDepViolation() {
     Schema billingAddressSchema = new StringSchema();