migrating ReferenceSchema to visitor model

Author: erosb

core/src/main/java/org/everit/json/schema/ReferenceSchema.java

@@ -56,14 +56,6 @@ public ReferenceSchema(final Builder builder) {
         this.refValue = requireNonNull(builder.refValue, "refValue cannot be null");
     }
 
-    @Override
-    public void validate(final Object subject) {
-        if (referredSchema == null) {
-            throw new IllegalStateException("referredSchema must be injected before validation");
-        }
-        referredSchema.validate(subject);
-    }
-
     @Override
     public boolean definesProperty(String field) {
         if (referredSchema == null) {
@@ -116,7 +108,7 @@ protected boolean canEqual(Object other) {
     }
 
     @Override void accept(Visitor visitor) {
-        throw new UnsupportedOperationException("not yet implemented");
+        visitor.visitReferenceSchema(this);
     }
 
     @Override void describePropertiesTo(JSONPrinter writer) {

core/src/main/java/org/everit/json/schema/ValidatingVisitor.java

@@ -72,6 +72,17 @@ private static boolean isNull(Object obj) {
         }
     }
 
+    @Override void visitReferenceSchema(ReferenceSchema referenceSchema) {
+        Schema referredSchema = referenceSchema.getReferredSchema();
+        if (referredSchema == null) {
+            throw new IllegalStateException("referredSchema must be injected before validation");
+        }
+        ValidationException failure = getFailureOfSchema(referredSchema, subject);
+        if (failure != null) {
+            failureReporter.failure(failure);
+        }
+    }
+
     ValidationException getFailureOfSchema(Schema schema, Object input) {
         Object origSubject = this.subject;
         this.subject = input;

core/src/main/java/org/everit/json/schema/Visitor.java

@@ -102,4 +102,7 @@ void visitFalseSchema(FalseSchema falseSchema) {
 
     void visitNotSchema(NotSchema notSchema) {
     }
+
+    void visitReferenceSchema(ReferenceSchema referenceSchema) {
+    }
 }

core/src/test/java/org/everit/json/schema/ReferenceSchemaTest.java

@@ -54,6 +54,18 @@ public void validationShouldDelegateToReferredSchema() {
                 .expect();
     }
 
+    @Test(expected = IllegalStateException.class)
+    public void validateThrowsExc_IfNoReferredSchemaIsSet() {
+        ReferenceSchema subject = ReferenceSchema.builder().build();
+        subject.validate(null);
+    }
+
+    @Test(expected = IllegalStateException.class)
+    public void definesPropertyThrowsExc_IfNoReferredSchemaIsSet() {
+        ReferenceSchema subject = ReferenceSchema.builder().build();
+        subject.definesProperty("propName");
+    }
+
     @Test
     public void equalsVerifier() {
         EqualsVerifier.forClass(ReferenceSchema.class)