Skip to content

Commit 7a345a0

Browse files
committed
making ValidatingVisitorTest#triggersCombinedSchemaEvents() pass
1 parent fcb7d3f commit 7a345a0

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

core/src/main/java/org/everit/json/schema/TrueSchema.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,8 @@ public void describeTo(JSONPrinter writer) {
3131
public String toString() {
3232
return "true";
3333
}
34+
35+
@Override public boolean equals(Object o) {
36+
return o instanceof TrueSchema && super.equals(o);
37+
}
3438
}

core/src/test/java/org/everit/json/schema/ValidatingVisitorTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import static org.junit.Assert.assertFalse;
44
import static org.junit.Assert.assertTrue;
5-
import static org.mockito.Matchers.any;
65
import static org.mockito.Mockito.mock;
76
import static org.mockito.Mockito.spy;
87
import static org.mockito.Mockito.verify;
@@ -12,6 +11,8 @@
1211
import java.math.BigInteger;
1312
import java.util.ArrayList;
1413

14+
import org.everit.json.schema.listener.CombinedSchemaMatchEvent;
15+
import org.everit.json.schema.listener.CombinedSchemaMismatchEvent;
1516
import org.everit.json.schema.listener.ValidationListener;
1617
import org.json.JSONArray;
1718
import org.json.JSONObject;
@@ -121,21 +122,22 @@ public void notPermittedTypeFailure(Object subject) {
121122
public void triggersCombinedSchemaEvents() {
122123
ValidationListener listener = mock(ValidationListener.class);
123124
StringSchema stringSchema = StringSchema.builder().requiresString(true).build();
124-
TrueSchema trueSchema = TrueSchema.builder().build();
125125
EmptySchema emptySchema = EmptySchema.builder().build();
126+
ObjectSchema objectSchema = ObjectSchema.builder().requiresObject(true).build();
126127
CombinedSchema combinedSchema = CombinedSchema.builder().criterion(CombinedSchema.ONE_CRITERION)
127128
.subschema(stringSchema)
128129
.subschema(emptySchema)
129-
// .subschema(trueSchema)
130+
.subschema(objectSchema)
130131
.build();
131132
ValidationFailureReporter reporter = spy(new CollectingFailureReporter(combinedSchema));
132133
JSONObject instance = new JSONObject();
133134

134135
new ValidatingVisitor(instance, reporter, ReadWriteValidator.NONE, listener).visit(combinedSchema);
135136

136-
verify(listener).combinedSchemaMismatch(any());
137-
verify(listener).combinedSchemaMatch(any()); //new CombinedSchemaValidationEvent(combinedSchema, trueSchema, instance)
138-
// verify(listener).combinedSchemaMatch(any()); //new CombinedSchemaValidationEvent(combinedSchema, emptySchema, instance)
137+
ValidationException exc = new ValidationException(stringSchema, String.class, instance);
138+
verify(listener).combinedSchemaMismatch(new CombinedSchemaMismatchEvent(combinedSchema, stringSchema, instance, exc));
139+
verify(listener).combinedSchemaMatch(new CombinedSchemaMatchEvent(combinedSchema, emptySchema, instance));
140+
verify(listener).combinedSchemaMatch(new CombinedSchemaMatchEvent(combinedSchema, objectSchema, instance));
139141
}
140142

141143
}

0 commit comments

Comments
 (0)